Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add management command to clear cache #1096

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add management command to clear cache #1096

merged 1 commit into from
Apr 22, 2024

Conversation

xmedr
Copy link
Collaborator

@xmedr xmedr commented Apr 18, 2024

Overview

Quick addition of a clear_cache command. The newest version of the release script in #1095 uses this command but deploying to staging raises an error because it currently doesn't exist.

Testing Instructions

  • Run python manage.py clear_cache on the review app
  • Confirm that the output ends in a success message

@fgregg fgregg temporarily deployed to la-metro-cou-feature-re-5azxnk April 18, 2024 14:32 Inactive
@xmedr xmedr marked this pull request as ready for review April 18, 2024 16:00
@xmedr xmedr requested a review from derekeder April 18, 2024 16:00
@derekeder
Copy link

@xmedr do we need this command? would it be better to remove it from the deploy script?

@xmedr
Copy link
Collaborator Author

xmedr commented Apr 22, 2024

@derekeder hm, no i don't think it's needed, but it might be a QOL addition. if we ever run into deployment issues that come about because of caching, we've just been going in and clearing it ourselves. but it does require that manual step after we notice it first.

i feel like @antidipyramid might have more insight on how useful this would be than i do, so i don't mind taking it out of the deploy script now and asking his opinion when he gets back!

@derekeder
Copy link

ok lets go ahead and bring this in so our deploy script doesn't error. it is a standard command in our other projects

@xmedr xmedr merged commit 3e62230 into main Apr 22, 2024
2 checks passed
@xmedr xmedr deleted the feature/review-apps branch April 22, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants