Enable review apps with the staging database #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekeder
approved these changes
Apr 17, 2024
| python manage.py migrate --noinput | ||
| python manage.py createcachetable | ||
| python manage.py import_shapes data/final/boundary.geojson | ||
| python manage.py clear_cache |
There was a problem hiding this comment.
this line seems new. i wonder why the cache wasn't getting cleared before. seems fine to include now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This alters the release script to look for either a signal that the app is running on either a production or staging environment.
The staging/production apps on heroku have a new boolean config var added to denote whether setup commands should be run.
Review apps have been set up with config vars nearly identical to the staging environment prior to opening this pr. They are also prepped to use the staging database instead of creating a new one every time a new review app gets made. The change in the release script is meant to prevent potential migrations on review apps from changing the staging db.
Smaller changes include updating the readme and clearing the cache on new releases. The nav would occasionally get formatted strangely and clearing the cache always solves this.
Testing Instructions
heroku releases:output v6 -a la-metro-cou-feature-re-zibkyfto see the output of the release marked as "Deploy"PRODUCTION or STAGING is not set, skipping setup management commandsto note that migrations were not run