Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: socket reconnection optimization #994

Merged
merged 33 commits into from
Aug 28, 2024

fix: authorized not reset after terminate

61bfe0e
Select commit
Loading
Failed to load commit list.
Merged

feat: socket reconnection optimization #994

fix: authorized not reset after terminate
61bfe0e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 28, 2024 in 0s

80.70% (+0.39%) compared to 9e9f1ac

View this Pull Request on Codecov

80.70% (+0.39%) compared to 9e9f1ac

Details

Codecov Report

Attention: Patch coverage is 69.78417% with 84 lines in your changes missing coverage. Please review.

Project coverage is 80.70%. Comparing base (9e9f1ac) to head (61bfe0e).

Files Patch % Lines
...kages/sdk/src/provider/initializeMobileProvider.ts 0.00% 21 Missing ⚠️
...oteConnection/ConnectionManager/startConnection.ts 69.56% 21 Missing ⚠️
...SocketService/ConnectionManager/reconnectSocket.ts 75.60% 10 Missing ⚠️
.../RemoteConnection/EventListeners/setupListeners.ts 58.82% 7 Missing ⚠️
packages/sdk/src/utils/base64.ts 33.33% 6 Missing ⚠️
...rvice/ConnectionManager/handleJoinChannelResult.ts 16.66% 5 Missing ⚠️
...oteCommunicationPostMessageStream/extractMethod.ts 66.66% 3 Missing ⚠️
...ices/SocketService/ChannelManager/createChannel.ts 85.71% 2 Missing ⚠️
...vice/ConnectionManager/setupSocketFocusListener.ts 87.50% 2 Missing ⚠️
packages/sdk/src/Platform/MetaMaskInstaller.ts 60.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   80.31%   80.70%   +0.39%     
==========================================
  Files         180      177       -3     
  Lines        4058     3990      -68     
  Branches     1007      990      -17     
==========================================
- Hits         3259     3220      -39     
+ Misses        799      770      -29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov