-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: socket reconnection optimization #994
Conversation
...ages/sdk-communication-layer/src/services/SocketService/ConnectionManager/reconnectSocket.ts
Show resolved
Hide resolved
packages/sdk-communication-layer/src/services/SocketService/EventListeners/handleSocketError.ts
Outdated
Show resolved
Hide resolved
|
||
document.getElementById('testLink').addEventListener('click', function () { | ||
console.log('Testing link:', currentLink); | ||
window.location.href = currentLink; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/providers@10.2.1) |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (re-approving)
Besides the high level changes described above, this PR also addresses long standing undetected bug when a connection is terminated from mobile, it is not possible to directly reconnect without refreshing the page.