-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump chromedriver from 99.0.0 to 119.0.1 #7747
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7747 +/- ##
=======================================
Coverage 36.70% 36.70%
=======================================
Files 1074 1074
Lines 28930 28930
Branches 2630 2630
=======================================
Hits 10620 10620
Misses 17712 17712
Partials 598 598 ☔ View full report in Codecov by Sentry. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
## **Description** Fix CI failing on Improved Yarn Audit step ```console metamask@7.10.0 /Users/leo/Documents/GitHub/metamask-mobile ├─┬ @consensys/on-ramp-sdk@1.23.0 │ └── axios@0.27.2 ├─┬ appium-adb@9.14.11 │ └─┬ @appium/support@4.1.6 │ └── axios@1.4.0 ├─┬ appium@1.22.3 │ ├─┬ appium-android-driver@4.54.0 │ │ ├─┬ appium-chromedriver@4.28.0 │ │ │ └── axios@0.27.2 │ │ └── axios@0.27.2 │ ├─┬ appium-base-driver@7.11.3 │ │ └── axios@0.27.2 │ ├─┬ appium-ios-driver@4.8.3 │ │ └── axios@0.27.2 │ ├─┬ appium-mac2-driver@0.14.1 │ │ └── axios@0.27.2 │ ├─┬ appium-support@2.55.0 │ │ └── axios@0.27.2 │ ├─┬ appium-uiautomator2-driver@1.75.0 │ │ └── axios@0.27.2 │ ├─┬ appium-xcuitest-driver@3.62.0 │ │ └─┬ appium-webdriveragent@3.17.0 │ │ └── axios@0.27.2 │ └── axios@0.27.2 ├── axios@0.26.1 └─┬ chromedriver@99.0.0 └── axios@0.24.0 ``` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** - CI broken past few hrs on Improved Yarn Audit step - GHSA-wf5p-g6vw-rhxx - #7747 worth looking at after ## **Manual testing steps** ```bash yarn audit:ci ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ```console Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx ``` ```console Vulnerability Found: Severity: MODERATE Modules: axios URL: GHSA-wf5p-g6vw-rhxx ``` ### **After** ```console ➜ metamask-mobile git:(fix/unbreak-ci-audit-fix-CVE-2023-45857) ✗ yarn audit:ci yarn run v1.22.19 warning ../package.json: No license field $ ./scripts/yarn-audit.sh warning ../package.json: No license field $ /Users/leo/Documents/GitHub/metamask-mobile/node_modules/.bin/improved-yarn-audit --ignore-dev-deps --min-severity moderate --fail-on-missing-exclusions Improved Yarn Audit - v3.0.0 Reading excluded advisories from .iyarc Minimum severity level to report: moderate Excluded Advisories: ["GHSA-p8p7-x288-28g6","GHSA-c2qf-rxjj-qqgw"] Running yarn audit... Found 0 vulnerabilities 2 ignored because they are dev dependencies 6 ignored because of advisory exclusions Run `yarn audit` for more information ✔ Audit shows _zero_ moderate or high severity advisories _in the production dependencies_ ✨ Done in 2.32s. ```
788a10b
to
b0d37d3
Compare
❌ https://github.com/MetaMask/metamask-mobile/actions/runs/6826142295/job/18565402337?pr=7747 npm run check-template-and-add-labels
GraphqlResponseError: Request failed due to following response errors:
- Could not resolve to a User with the login of 'dependabot'.
at /home/runner/work/metamask-mobile/metamask-mobile/node_modules/@octokit/graphql/dist-src/graphql.js:48:19
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at async userBelongsToMetaMaskOrg (/home/runner/work/metamask-mobile/metamask-mobile/.github/scripts/check-template-and-add-labels.ts:292:7)
at async main (/home/runner/work/metamask-mobile/metamask-mobile/.github/scripts/check-template-and-add-labels.ts:76:9) {
request: {
query: '\n' +
' query UserBelongsToMetaMaskOrg($login: String!) {\n' +
' user(login: $login) {\n' +
' organization(login: "MetaMask") {\n' +
' id\n' +
# ... |
## **Description** Fix CI failing on Improved Yarn Audit step ```console metamask@7.10.0 /Users/leo/Documents/GitHub/metamask-mobile ├─┬ @consensys/on-ramp-sdk@1.23.0 │ └── axios@0.27.2 ├─┬ appium-adb@9.14.11 │ └─┬ @appium/support@4.1.6 │ └── axios@1.4.0 ├─┬ appium@1.22.3 │ ├─┬ appium-android-driver@4.54.0 │ │ ├─┬ appium-chromedriver@4.28.0 │ │ │ └── axios@0.27.2 │ │ └── axios@0.27.2 │ ├─┬ appium-base-driver@7.11.3 │ │ └── axios@0.27.2 │ ├─┬ appium-ios-driver@4.8.3 │ │ └── axios@0.27.2 │ ├─┬ appium-mac2-driver@0.14.1 │ │ └── axios@0.27.2 │ ├─┬ appium-support@2.55.0 │ │ └── axios@0.27.2 │ ├─┬ appium-uiautomator2-driver@1.75.0 │ │ └── axios@0.27.2 │ ├─┬ appium-xcuitest-driver@3.62.0 │ │ └─┬ appium-webdriveragent@3.17.0 │ │ └── axios@0.27.2 │ └── axios@0.27.2 ├── axios@0.26.1 └─┬ chromedriver@99.0.0 └── axios@0.24.0 ``` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** - CI broken past few hrs on Improved Yarn Audit step - GHSA-wf5p-g6vw-rhxx - #7747 worth looking at after ## **Manual testing steps** ```bash yarn audit:ci ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ```console Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx ``` ```console Vulnerability Found: Severity: MODERATE Modules: axios URL: GHSA-wf5p-g6vw-rhxx ``` ### **After** ```console ➜ metamask-mobile git:(fix/unbreak-ci-audit-fix-CVE-2023-45857) ✗ yarn audit:ci yarn run v1.22.19 warning ../package.json: No license field $ ./scripts/yarn-audit.sh warning ../package.json: No license field $ /Users/leo/Documents/GitHub/metamask-mobile/node_modules/.bin/improved-yarn-audit --ignore-dev-deps --min-severity moderate --fail-on-missing-exclusions Improved Yarn Audit - v3.0.0 Reading excluded advisories from .iyarc Minimum severity level to report: moderate Excluded Advisories: ["GHSA-p8p7-x288-28g6","GHSA-c2qf-rxjj-qqgw"] Running yarn audit... Found 0 vulnerabilities 2 ignored because they are dev dependencies 6 ignored because of advisory exclusions Run `yarn audit` for more information ✔ Audit shows _zero_ moderate or high severity advisories _in the production dependencies_ ✨ Done in 2.32s. ```
## **Description** Fix CI failing on Improved Yarn Audit step ```console metamask@7.10.0 /Users/leo/Documents/GitHub/metamask-mobile ├─┬ @consensys/on-ramp-sdk@1.23.0 │ └── axios@0.27.2 ├─┬ appium-adb@9.14.11 │ └─┬ @appium/support@4.1.6 │ └── axios@1.4.0 ├─┬ appium@1.22.3 │ ├─┬ appium-android-driver@4.54.0 │ │ ├─┬ appium-chromedriver@4.28.0 │ │ │ └── axios@0.27.2 │ │ └── axios@0.27.2 │ ├─┬ appium-base-driver@7.11.3 │ │ └── axios@0.27.2 │ ├─┬ appium-ios-driver@4.8.3 │ │ └── axios@0.27.2 │ ├─┬ appium-mac2-driver@0.14.1 │ │ └── axios@0.27.2 │ ├─┬ appium-support@2.55.0 │ │ └── axios@0.27.2 │ ├─┬ appium-uiautomator2-driver@1.75.0 │ │ └── axios@0.27.2 │ ├─┬ appium-xcuitest-driver@3.62.0 │ │ └─┬ appium-webdriveragent@3.17.0 │ │ └── axios@0.27.2 │ └── axios@0.27.2 ├── axios@0.26.1 └─┬ chromedriver@99.0.0 └── axios@0.24.0 ``` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** - CI broken past few hrs on Improved Yarn Audit step - GHSA-wf5p-g6vw-rhxx - #7747 worth looking at after ## **Manual testing steps** ```bash yarn audit:ci ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ```console Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx ``` ```console Vulnerability Found: Severity: MODERATE Modules: axios URL: GHSA-wf5p-g6vw-rhxx ``` ### **After** ```console ➜ metamask-mobile git:(fix/unbreak-ci-audit-fix-CVE-2023-45857) ✗ yarn audit:ci yarn run v1.22.19 warning ../package.json: No license field $ ./scripts/yarn-audit.sh warning ../package.json: No license field $ /Users/leo/Documents/GitHub/metamask-mobile/node_modules/.bin/improved-yarn-audit --ignore-dev-deps --min-severity moderate --fail-on-missing-exclusions Improved Yarn Audit - v3.0.0 Reading excluded advisories from .iyarc Minimum severity level to report: moderate Excluded Advisories: ["GHSA-p8p7-x288-28g6","GHSA-c2qf-rxjj-qqgw"] Running yarn audit... Found 0 vulnerabilities 2 ignored because they are dev dependencies 6 ignored because of advisory exclusions Run `yarn audit` for more information ✔ Audit shows _zero_ moderate or high severity advisories _in the production dependencies_ ✨ Done in 2.32s. ``` ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: # ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 99.0.0 to 119.0.1. - [Commits](giggio/node-chromedriver@99.0.0...119.0.1) --- updated-dependencies: - dependency-name: chromedriver dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
b0d37d3
to
fa120a5
Compare
PR deprecated by #9133 |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps chromedriver from 99.0.0 to 119.0.1.
Commits
de961e3
Hide private attributes from exports379046e
Update package dependencies5b708ad
Add tests for Node.js version 21c99283d
Bump version to 119.0.0f6edc1e
Add provenancef43d7f8
Make install faster for update check157d419
Add token to enable PR09dd5b7
Bump version to 118.0.082a6380
Fix tag gh action scriptce13f36
Bump package version to 117.0.3You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.