Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display nft media setting copy improvement #7293

Merged
merged 5 commits into from
Oct 9, 2023
+5 −3
Merged

feat: display nft media setting copy improvement #7293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae4d86a
display nft media setting copy improvement
tommasini Sep 22, 2023
d1d431c
Merge branch 'main' into translations/display-nft-media-copy-improvement
tommasini Sep 23, 2023
ddb9c1f
Merge branch 'main' into translations/display-nft-media-copy-improvement
tommasini Sep 27, 2023
cfb734b
Merge branch 'main' into translations/display-nft-media-copy-improvement
tommasini Sep 28, 2023
88b2920
Merge branch 'main' into translations/display-nft-media-copy-improvement
tommasini Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/Views/Settings/SecuritySettings/SecuritySettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ const Settings: React.FC = () => {
{strings('app_settings.display_nft_media')}
</Text>
<Text style={styles.desc}>
{strings('app_settings.display_nft_media_desc')}
{strings('app_settings.display_nft_media_desc_new')}
</Text>
<View style={styles.switchElement}>
<Switch
Expand Down
2 changes: 1 addition & 1 deletion app/components/Views/Settings/SecuritySettings/__snapshots__/SecuritySettings.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1675,7 +1675,7 @@ exports[`SecuritySettings should render correctly 1`] = `
}
}
>
Displaying NFT media and data exposes your IP address to OpenSea or other third parties. NFT autodetection relies on this feature, and won't be available when this is turned off.
Displaying NFT media and data exposes your IP address to OpenSea or other third parties. NFT autodetection relies on this feature, and won't be available when turned off. If NFT media is fully located on IPFS, it can still be displayed even when this feature is turned off.
</Text>
<View
style={
Expand Down
4 changes: 3 additions & 1 deletion locales/languages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,9 @@
"display_nft_media_desc": "Displaying NFT media and data exposes your IP address to OpenSea or other third parties. NFT autodetection relies on this feature, and won't be available when this is turned off.",
"autodetect_nft_desc": "Let MetaMask add NFTs you own using third-party services (like OpenSea). Autodetecting NFTs exposes your IP and account address to these services. Enabling this feature could associate your IP address with your Ethereum address and display fake NFTs airdropped by scammers. You can add tokens manually to avoid this risk.",
"incoming_transactions_title": "Show incoming transactions",
"incoming_transactions_content": "This relies on the network you select which will expose your Ethereum address and your IP address."
"incoming_transactions_content": "This relies on the network you select which will expose your Ethereum address and your IP address.",
"display_nft_media_desc_new": "Displaying NFT media and data exposes your IP address to OpenSea or other third parties. NFT autodetection relies on this feature, and won't be available when turned off. If NFT media is fully located on IPFS, it can still be displayed even when this feature is turned off."

},
"sdk": {
"disconnect_title": "Disconnect all sites?",
Expand Down
Loading