Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display nft media setting copy improvement #7293

Merged
merged 5 commits into from
Oct 9, 2023
Merged

feat: display nft media setting copy improvement #7293

merged 5 commits into from
Oct 9, 2023

Conversation

tommasini
Copy link
Contributor

Description

Translation improvement for copy on display nft media setting

Screenshots/Recordings

image

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-7.9.0 Issue or pull request that will be included in release 7.9.0 labels Sep 22, 2023
@tommasini tommasini requested a review from a team as a code owner September 22, 2023 15:03
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Cal-L
Cal-L reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ce22421) 34.60% compared to head (ddb9c1f) 34.60%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7293   +/-   ##
=======================================
  Coverage   34.60%   34.60%           
=======================================
  Files        1017     1017           
  Lines       27144    27144           
  Branches     2205     2205           
=======================================
  Hits         9393     9393           
  Misses      17262    17262           
  Partials      489      489
Files Coverage Δ
...ews/Settings/SecuritySettings/SecuritySettings.tsx 53.57% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini requested a review from Cal-L September 22, 2023 15:36
@sethkfman sethkfman added release-7.10.0 Issue or pull request that will be included in release 7.10.0 and removed release-7.9.0 Issue or pull request that will be included in release 7.9.0 labels Sep 28, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

NicolasMassart
NicolasMassart approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tommasini tommasini merged commit 4c0879b into main Oct 9, 2023
25 checks passed
@tommasini tommasini deleted the translations/display-nft-media-copy-improvement branch October 9, 2023 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 9, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@Cal-L Cal-L Awaiting requested review from Cal-L

Assignees
No one assigned
Labels
release-7.10.0 Issue or pull request that will be included in release 7.10.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tommasini @codecov-commenter @NicolasMassart @Cal-L @gauthierpetetin @sethkfman