Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deduplicate remaining dependencies; add deduplicate script #7131

Merged
merged 5 commits into from
Oct 17, 2023
Merged

chore: Deduplicate remaining dependencies; add deduplicate script #7131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a98f80
Deduplicate dependencies
Gudahtt Jul 25, 2023
59fb30c
run yarn deduplicate
legobeat Sep 4, 2023
1638492
chore: update allow-scripts config with new appium/**/core-js entries
legobeat Oct 2, 2023
4079dc6
ci: run yarn install after deduplicate
legobeat Oct 12, 2023
1f6d495
Merge branch 'main' into deps-dedupe-rebased
legobeat Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,25 @@ jobs:
echo "Working tree dirty at end of job"
exit 1
fi
dedupe:
runs-on: ubuntu-20.04
needs: setup
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version-file: '.nvmrc'
cache: yarn
- run: yarn setup:node
- name: Deduplicate dependencies
run: yarn deduplicate && yarn
- name: Print error if duplicates found
shell: bash
run: |
if ! git diff --exit-code; then
echo "Duplicate dependencies detected; run 'yarn deduplicate' to remove them"
exit 1
fi
scripts:
runs-on: ubuntu-20.04
needs: setup
Expand Down Expand Up @@ -166,6 +185,6 @@ jobs:
all-jobs-pass:
name: All jobs pass
runs-on: ubuntu-20.04
needs: [setup, scripts, unit-tests, check-workflows, sonar-cloud]
needs: [setup, dedupe, scripts, unit-tests, check-workflows, sonar-cloud]
steps:
- run: echo "Great success!"
8 changes: 6 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
"stacktrace:ios": "stack-beautifier sourcemaps/ios/index.js.map -t sourcemaps/trace.txt",
"update-changelog": "./scripts/auto-changelog.sh",
"prestorybook": "rnstl",
"deduplicate": "yarn yarn-deduplicate",
"create-release": "./scripts/set-versions.sh && yarn update-changelog",
"add-release-label-to-pr-and-linked-issues": "ts-node ./.github/scripts/add-release-label-to-pr-and-linked-issues.ts",
"check-pr-has-required-labels": "ts-node ./.github/scripts/check-pr-has-required-labels.ts",
Expand Down Expand Up @@ -470,7 +471,8 @@
"ts-node": "^10.5.0",
"typescript": "~4.8.4",
"wdio-cucumberjs-json-reporter": "^4.4.3",
"xml2js": "^0.5.0"
"xml2js": "^0.5.0",
"yarn-deduplicate": "^6.0.2"
},
"config": {
"react-native-storybook-loader": {
Expand Down Expand Up @@ -654,7 +656,9 @@
"ethereumjs-abi>ethereumjs-util>ethereum-cryptography>keccak": true,
"ethereumjs-abi>ethereumjs-util>ethereum-cryptography>secp256k1": true,
"@metamask/signature-controller>@metamask/message-manager>ethereumjs-util>ethereum-cryptography>keccak": true,
"@metamask/signature-controller>@metamask/message-manager>ethereumjs-util>ethereum-cryptography>secp256k1": true
"@metamask/signature-controller>@metamask/message-manager>ethereumjs-util>ethereum-cryptography>secp256k1": true,
"appium>appium-tizen-driver>jimp>@babel/polyfill>core-js": false,
"appium>appium-tizen-driver>jimp>core-js": false
}
}
}
Loading
Loading