-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Deduplicate remaining dependencies; add deduplicate script #7131
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
219dcee
to
31c2d0a
Compare
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @types/lodash@4.14.186, @types/qs@6.9.7, @walletconnect/jsonrpc-types@1.0.2, eciesjs@0.3.15 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
dedupes-diff.txt |
31c2d0a
to
837db7e
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7131 +/- ##
=======================================
Coverage 34.62% 34.62%
=======================================
Files 1019 1019
Lines 27192 27192
Branches 2217 2217
=======================================
Hits 9414 9414
Misses 17287 17287
Partials 491 491 ☔ View full report in Codecov by Sentry. |
cd8677e
to
26bd973
Compare
f0b7f2d
to
4596671
Compare
4596671
to
1f3df4e
Compare
new author ok |
|
3452840
to
888fec0
Compare
A `deduplicate` script has been added to `package.json`, which allows deduplicating dependencies in the lockfile. This feature is built-in as part of Yarn v3, but on Yarn v1 it's provided by the `yarn-deduplicate` package. It has been run, so the lockfile has been purged of unnecessary copies of dependencies. This means many dependencies have been updated, but it should result in no breakages as long as all affected packages are SemVer-compliant or handled by one of our resolutions. Additionally, a CI check has been added to ensure dependencies are always deduplicated. If duplicates are detected, the error from CI will explain how to remove them.
888fec0
to
4079dc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹🤖
#7123 but split up dedupes and rebased on:
ethers
@5.* #7128Description
A
deduplicate
script has been added topackage.json
, which allows deduplicating dependencies in the lockfile. This feature is built-in as part of Yarn v3, but on Yarn v1 it's provided by theyarn-deduplicate
package.It has been run, so the lockfile has been purged of unnecessary copies of dependencies. This means many dependencies have been updated, but it should result in no breakages as long as all affected packages are SemVer-compliant or handled by one of our resolutions.
A CI check has been added to ensure dependencies are always deduplicated. If duplicates are detected, the error from CI will explain how to remove them.
Issue
No related issue
Checklist