chore(runway): cherry-pick fix: cp-7.42.0 enable notifications UI #13906
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable notifications for main (& the 7.42.0 release).
Related issues
Manual testing steps
I'll be creating a QA doc for testing this feature (inc. demos).
Enable/Disable Notifications Flow
multiple services to register notifications for this user.
multiple services.
Enable/Disable Push Notifications
in the UI).
multiple services.
Enable/Disable Feature Annonucements
fully tested post launch or in dev).
Enable/Disable Account Notifications
multiple services. We have plans to improve this flow (allow users to
toggle multiple accounts and save changes).
in our DB, re-enabling account notifications will not return the
previous notifications you may have had.
Push Notifications:
you have accounts with notifications enabled.
notifications.
is in the background or killed. Foreground notifications are not
supported due to compatibility issues between IOS/Android (duplicate
notification issues, notifications not showing due to device level
properties). I've created a ticket to investigate this.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. 260866e