Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cp-7.42.0 enable notifications UI #13877

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Mar 6, 2025

Description

Enable notifications for main (& the 7.42.0 release).

Related issues

Manual testing steps

I'll be creating a QA doc for testing this feature (inc. demos).

Enable/Disable Notifications Flow

  1. Onboard wallet
  2. Click Bell Icon > Click Enable Notifications
    • Expected: Notifications should become enabled.
    • NOTE - this may take a little while as we need to communicate to multiple services to register notifications for this user.
  3. Visit Settings/Notifications > Click Disable Notifications
    • Expected: Notifications should become disabled.
    • NOTE - this may take a little while as we need to communicate to multiple services.

Enable/Disable Push Notifications

  1. Onboard + Enable Notifications
  2. Visit Settings/Notifications
  3. Toggle Push Notifications Enabled/Disabled.
    • Expected: This should toggle the switch (no other changes will occur in the UI).
    • NOTE - this may take a little while as we need to communicate to multiple services.

Enable/Disable Feature Annonucements

  • N/A as there are no announcements released on Mobile (this will be fully tested post launch or in dev).

Enable/Disable Account Notifications

  1. Onboard + Enable Notifications
  2. Visit Settings/Notifications
  3. Toggle Account Notifications Enabled/Disabled.
  • Expected: This should toggle notifications on/off for your accounts.
  • NOTE - this may take a little while as we need to communicate to multiple services. We have plans to improve this flow (allow users to toggle multiple accounts and save changes).
  • NOTE - disabling notifications will also clear existing notifications in our DB, re-enabling account notifications will not return the previous notifications you may have had.

Push Notifications:

  1. Onboard + Enable Notifications + Enable Push Notifications + Ensure you have accounts with notifications enabled.
  2. Minimise or close the app
  3. In a different device, perform a send/swap on your account with notifications.
  • Expected: You should see push notifications on your mobile device
  • NOTE - push notifications are only send and our visible when the app is in the background or killed. Foreground notifications are not supported due to compatibility issues between IOS/Android (duplicate notification issues, notifications not showing due to device level properties). I've created a ticket to investigate this.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner March 6, 2025 11:31
Copy link
Contributor

github-actions bot commented Mar 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0fd5c10
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d11aa0fd-7d80-4252-9ba6-9f87dcbce60e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Prithpal-Sooriya Prithpal-Sooriya changed the title build: cp-7.42.0 enable notifications UI fix: cp-7.42.0 enable notifications UI Mar 6, 2025
@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 613151d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/95d3c78e-9ece-4fd8-ae29-f81b8c2e8127

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Mar 6, 2025

@MarioAslau MarioAslau added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit 260866e Mar 6, 2025
45 checks passed
@MarioAslau MarioAslau deleted the MMASSETS-623/enable-notifications-ui-flag branch March 6, 2025 22:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants