Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cp-7.42.0 Display account label in re-designs confirmation page account info section #13853

Merged
merged 14 commits into from
Mar 6, 2025
Merged

fix: cp-7.42.0 Display account label in re-designs confirmation page account info section #13853

merged 14 commits into from
Mar 6, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Mar 5, 2025

Description

Display account label in re-designs confirmation page account info section

Related issues

Fixes: #13731
Fixes: #13795

Manual testing steps

  1. To to ledger / QR account
  2. Open any signature page
  3. Check label next to account name

Screenshots/Recordings

Screenshot 2025-03-05 at 12 51 40 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Mar 5, 2025
@jpuri jpuri requested a review from a team as a code owner March 5, 2025 07:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

digiwand
digiwand requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion to use TagBase, or another DS component rather than creating new styles

https://github.com/MetaMask/metamask-mobile/pull/13853/files#r1980883678

digiwand
digiwand reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the screenshot, I saw the title and subtitle are missing horizontal padding. I added a fix for it in this PR which fixes permit simulation styles

#13830

@jpuri jpuri requested a review from digiwand March 5, 2025 08:18
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 370cdd9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c8e9fcaf-625a-49eb-abd6-e880a173f802

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri requested a review from OGPoyraz March 5, 2025 11:40
OGPoyraz
OGPoyraz previously approved these changes Mar 5, 2025
View reviewed changes
@jpuri jpuri enabled auto-merge March 5, 2025 15:55
@MarioAslau MarioAslau changed the title fix: Display account label in re-designs confirmation page account info section fix: cp-7.42.0 Display account label in re-designs confirmation page account info section Mar 5, 2025
@MarioAslau MarioAslau changed the title fix: cp-7.42.0 Display account label in re-designs confirmation page account info section fix: cp-7.42.0 cp-7.42.0 Display account label in re-designs confirmation page account info section Mar 5, 2025
@MarioAslau MarioAslau changed the title fix: cp-7.42.0 cp-7.42.0 Display account label in re-designs confirmation page account info section fix: cp-7.42.0 Display account label in re-designs confirmation page account info section Mar 5, 2025
@jpuri @digiwand
Update app/components/Views/confirmations/components/Confirm/AccountN…
7b98ca7 
…etworkInfo/AccountNetworkInfoCollapsed/AccountNetworkInfoCollapsed.styles.ts

Co-authored-by: digiwand <20778143+digiwand@users.noreply.github.com>
@jpuri jpuri requested review from digiwand and OGPoyraz March 6, 2025 06:40
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 04b7bca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4784991f-5a2c-4c1f-98a1-5dad4e149d38

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit 30a34ec Mar 6, 2025
42 of 43 checks passed
@jpuri jpuri deleted the account_label_fix branch March 6, 2025 15:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@OGPoyraz OGPoyraz Awaiting requested review from OGPoyraz

Assignees
No one assigned
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
4 participants
@jpuri @OGPoyraz @digiwand @metamaskbot