Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Permit Simulation vertical overflow, title padding, and collapsed message alignment #13830

Merged
merged 7 commits into from
Mar 5, 2025

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Mar 4, 2025

Description

Fix vertical overflow

additionally:

  • add padding horizontal to title and subtitle
  • fix Message collapsed vertical centering and remove extra bottom padding

Related issues

Fixes: #13829

Manual testing steps

  1. Go to test-dapp
  2. test permit simulation

Screenshots/Recordings

Before

CleanShot 2025-03-04 at 06 17 07@2x
CleanShot 2025-03-04 at 06 17 21@2x

Before, observe missing title and subtitle padding:

After

CleanShot 2025-03-04 at 05 58 56@2x
CleanShot 2025-03-04 at 05 59 18@2x
CleanShot 2025-03-04 at 06 03 31@2x

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner March 4, 2025 14:16
Copy link
Contributor

github-actions bot commented Mar 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Mar 4, 2025
@digiwand digiwand added No E2E Smoke Needed If the PR does not need E2E smoke test run Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ddfadc6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ee3f5f68-42c7-4abb-9217-c7b5f1e31fad

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@digiwand digiwand requested a review from a team as a code owner March 5, 2025 07:37
@digiwand digiwand enabled auto-merge March 5, 2025 15:51
@digiwand digiwand changed the title fix: Permit Simulation vertical overflow fix: Permit Simulation vertical overflow, title padding, and collapsed message alignment Mar 5, 2025
@digiwand digiwand added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 9bfd868 Mar 5, 2025
46 of 47 checks passed
@digiwand digiwand deleted the fix-permit-simulation-overflow-wrapped-values branch March 5, 2025 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Permit simulation is overflowing when single value and address are wrapped
6 participants