Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify cicd rls script #12413

Merged
merged 1 commit into from
Nov 25, 2024
Merged

chore: simplify cicd rls script #12413

merged 1 commit into from
Nov 25, 2024

Conversation

jake-perkins
Copy link
Contributor

@jake-perkins jake-perkins commented Nov 25, 2024

Description

Update the create release script to always assume the release branch has been created already

Related issues

Fixes:
https://github.com/MetaMask/metamask-mobile/actions/runs/11864495205/job/33068035826

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A - CI/CD Only

After

N/A - CI/CD Only

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jake-perkins jake-perkins requested a review from a team as a code owner November 25, 2024 15:22
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label Nov 25, 2024
@jake-perkins jake-perkins added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 25, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jake-perkins jake-perkins added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit a74aa71 Nov 25, 2024
61 of 63 checks passed
@jake-perkins jake-perkins deleted the rls-script-fixes branch November 25, 2024 16:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.37.0 Issue or pull request that will be included in release 7.37.0 team-dev-ops DevOps team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants