Skip to content

Commit

Permalink
chore: simplify cicd rls script (#12413)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Update the create release script to always assume the release branch has
been created already

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: 

https://github.com/MetaMask/metamask-mobile/actions/runs/11864495205/job/33068035826

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

N/A - CI/CD Only

### **After**

<!-- [screenshots/recordings] -->

N/A - CI/CD Only

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
jake-perkins authored Nov 25, 2024
1 parent 354c296 commit a74aa71
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions scripts/create-release-pr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,9 @@ git config user.email metamaskbot@users.noreply.github.com
echo "Fetching from remote..."
git fetch

# Check if the release branch already exists on the remote
if git branch -a | grep -q "remotes/origin/${RELEASE_BRANCH_NAME}"; then
echo "Release branch exists on remote, checking out."
git checkout "${RELEASE_BRANCH_NAME}"
else
echo "Release branch does not exist on remote, creating from ${BASE_BRANCH}."
git checkout -b "${RELEASE_BRANCH_NAME}"
fi
# Check out the existing release branch from the remote
echo "Checking out the release branch: ${RELEASE_BRANCH_NAME}"
git checkout "${RELEASE_BRANCH_NAME}"

echo "Release Branch Checked Out"

Expand Down

0 comments on commit a74aa71

Please sign in to comment.