Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade assets controllers to v44 #12344

Merged
merged 54 commits into from
Nov 26, 2024
Merged

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 20, 2024

Description

Upgrades the assets controllers to v44. In this version, the token balances controller now stores erc20 balances across all chains and accounts, instead of just the current chain and account like before. This allows polling erc20 balances across chains.

Related issues

Depends on: #12340

Manual testing steps

With PORTFOLIO_VIEW=false and PORTFOLIO_VIEW=true:

  1. Onboard
  2. Verify erc20 tokens have correct balances
  3. Switch chains
  4. Verify the erc20 tokens on the new chain have correct balances
  5. Send a TX that changes an erc20 balance
  6. Verify it gets updated after tx completes

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 21, 2024
salimtb
salimtb previously approved these changes Nov 21, 2024
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 794ad13
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2b53becd-ca15-4157-8fd4-9b0f1065eea4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@OGPoyraz OGPoyraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmation changes (only tests as far as I see) looks fine

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update needs a migration to clean the contractBalances from the user data
https://github.com/MetaMask/core/pull/4782/files#diff-09448a98d6ea70ebb5f28c2d45687d07bfb5beef1db71d326bf151e6246e410dR42

But it can be a follow up PR

It would be nice to have some recordings as well

Copy link
Contributor

@christopherferreira9 christopherferreira9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salimtb salimtb added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 16a6d6e Nov 26, 2024
37 checks passed
@salimtb salimtb deleted the brian/asset-controller-44 branch November 26, 2024 17:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 26, 2024
@salimtb salimtb added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants