-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade assets controllers to v44 #12344
Conversation
…tamask-mobile into brian/assets-controllers-43
…tamask-mobile into brian/assets-controllers-43
Bitrise✅✅✅ Commit hash: 794ad13 Note
|
app/components/Views/SDK/SDKSessionsManager/SDKSessionAccountListItem.test.tsx
Show resolved
Hide resolved
...ews/confirmations/components/TransactionReview/TransactionReviewEIP1559Update/index.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmation changes (only tests as far as I see) looks fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update needs a migration to clean the contractBalances
from the user data
https://github.com/MetaMask/core/pull/4782/files#diff-09448a98d6ea70ebb5f28c2d45687d07bfb5beef1db71d326bf151e6246e410dR42
But it can be a follow up PR
It would be nice to have some recordings as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Description
Upgrades the assets controllers to v44. In this version, the token balances controller now stores erc20 balances across all chains and accounts, instead of just the current chain and account like before. This allows polling erc20 balances across chains.
Related issues
Depends on: #12340
Manual testing steps
With PORTFOLIO_VIEW=false and PORTFOLIO_VIEW=true:
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist