Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade assets controllers to version 43 #12340

Merged
merged 32 commits into from
Nov 21, 2024
Merged

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 19, 2024

Description

Upgrades the assets controllers to versiom 43, which allows polling for token detection and token lists across chains.

It also lets us remove the patch for staking.

Related issues

Depends on: #12270

Manual testing steps

With PORTFOLIO_VIEW=false and PORTFOLIO_VIEW=true:

  1. Onboard
  2. Verify erc20 tokens are detected correctly
  3. Switch chains
  4. Verify they're detected correctly on the new chain

Screenshots/Recordings

No visual changes

Before

After

Screen.Recording.2024-11-20.at.9.18.27.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the base branch from main to brian/multichain-token-rates November 19, 2024 22:24
Copy link

socket-security bot commented Nov 19, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@43.1.1 None +1 2.12 MB danfinlay, gudahtt, kumavis, ...7 more

🚮 Removed packages: npm/@metamask/assets-controllers@42.0.0

View full report↗︎

@bergeron bergeron requested review from a team as code owners November 19, 2024 23:33
@bergeron bergeron marked this pull request as draft November 19, 2024 23:33
Base automatically changed from brian/multichain-token-rates to main November 20, 2024 16:53
@bergeron bergeron marked this pull request as ready for review November 20, 2024 17:01
@bergeron bergeron added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f6f7646
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f6e22f54-3c2f-4ecb-81d8-31b8a52fbc79

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bergeron bergeron added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 09bc62b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8ff171f9-118c-4f15-8568-e17ef10cff69

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bergeron bergeron added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 20, 2024
@bergeron bergeron enabled auto-merge November 21, 2024 01:32
@bergeron bergeron added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 0e0b8b0 Nov 21, 2024
49 checks passed
@bergeron bergeron deleted the brian/assets-controllers-43 branch November 21, 2024 01:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants