Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multichain polling hook #12171

Merged
merged 16 commits into from
Nov 11, 2024
Merged

feat: multichain polling hook #12171

merged 16 commits into from
Nov 11, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 4, 2024

Description

Adds a usePolling hook that handles starting and stopping polling loops for polling controllers. This will be used to poll across chains, and eventually make more polling UI based so we're only polling data when UI components require it.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the base branch from cryptodev2s/bump-assets-controllers-v39 to main November 4, 2024 21:12
@bergeron bergeron changed the base branch from main to cryptodev2s/bump-assets-controllers-v39 November 4, 2024 21:14
@bergeron bergeron changed the title Multichain asset polling multichain polling hooks Nov 4, 2024
Base automatically changed from cryptodev2s/bump-assets-controllers-v39 to main November 5, 2024 09:05
@bergeron bergeron changed the base branch from main to chore/upgrade-assets-controllers-v41.0.0 November 7, 2024 23:10
@bergeron bergeron changed the base branch from chore/upgrade-assets-controllers-v41.0.0 to main November 7, 2024 23:11
@bergeron bergeron changed the title multichain polling hooks feat: multichain polling hook Nov 7, 2024
@bergeron bergeron marked this pull request as ready for review November 7, 2024 23:14
@bergeron bergeron requested a review from a team as a code owner November 7, 2024 23:14
@bergeron bergeron added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 7, 2024
Copy link

sonarqubecloud bot commented Nov 7, 2024

@bergeron bergeron enabled auto-merge November 8, 2024 00:10
@bergeron bergeron added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2024
@bergeron bergeron added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 940258e Nov 11, 2024
40 checks passed
@bergeron bergeron deleted the multichain-polling branch November 11, 2024 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.36.0 Issue or pull request that will be included in release 7.36.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants