Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade assets-controllers to v41 #12178

Merged
merged 12 commits into from
Nov 8, 2024
Merged

chore: upgrade assets-controllers to v41 #12178

merged 12 commits into from
Nov 8, 2024
+64 −201

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Nov 5, 2024 •
edited
Loading

Description

Bump assets-controllers to v41

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2024-11-08.at.19.25.38.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 5, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Nov 5, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@41.0.0 None +4 3.02 MB metamaskbot
npm/@metamask/polling-controller@12.0.1 None 0 105 kB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@39.0.0, npm/@metamask/polling-controller@11.0.0

View full report↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cf07c3d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6515fe40-02f5-4b3f-ad29-808b18fff0d6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d27c269
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3975ee4d-b696-4051-a4d3-6ec4b1e17fee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review November 5, 2024 15:27
@sahar-fehri sahar-fehri requested review from a team as code owners November 5, 2024 15:27
bergeron
bergeron reviewed Nov 5, 2024
View reviewed changes
app/core/Engine.ts Outdated Show resolved Hide resolved
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 5, 2024
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 44e937f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c8f062f4-e6b1-4668-91fb-207c7463ed0d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
bergeron
bergeron previously approved these changes Nov 7, 2024
View reviewed changes
bergeron
bergeron previously approved these changes Nov 7, 2024
View reviewed changes
@bergeron bergeron added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6326def
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/764c3b34-148e-40f1-88d7-a566e3b8b23b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bergeron
fix unit test
0fa02f1
@bergeron
Merge branch 'chore/upgrade-assets-controllers-v41.0.0' of github.com…
98a0056 
…:MetaMask/metamask-mobile into chore/upgrade-assets-controllers-v41.0.0
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bergeron bergeron added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b7bf420
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/724acc00-6c5c-4768-9439-f5cbdea59492

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bergeron bergeron enabled auto-merge November 8, 2024 00:37
tommasini
tommasini approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bergeron bergeron added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 1ec8742 Nov 8, 2024
45 checks passed
@bergeron bergeron deleted the chore/upgrade-assets-controllers-v41.0.0 branch November 8, 2024 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@bergeron bergeron bergeron approved these changes

@darkwing darkwing darkwing approved these changes

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sahar-fehri @darkwing @bergeron @tommasini @gauthierpetetin @metamaskbot