fix: Reapply migration 52 to fix undefined selectedAccount #12115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
added
Run Smoke E2E
Cal-L
changed the title
Cal-L
commented
Oct 31, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12115 +/- ##
==========================================
+ Coverage 55.35% 55.57% +0.22%
==========================================
Files 1767 1781 +14
Lines 39841 40086 +245
Branches 4965 5001 +36
==========================================
+ Hits 22052 22279 +227
- Misses 16274 16283 +9
- Partials 1515 1524 +9 ☔ View full report in Codecov by Sentry. |
|
NicolasMassart
approved these changes
Oct 31, 2024
tommasini
approved these changes
Oct 31, 2024
Gudahtt
reviewed
Oct 31, 2024
Gudahtt
approved these changes
Oct 31, 2024
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.35.0
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> These changes refactors migration 52 and 57 to use consolidated logic. Comments was also added explaining that the migrations are the same ## **Related issues** Fixes: #12115 ## **Manual testing steps** Follow same steps in PR #12115 ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #11866 where it ensures that selectedAccount in the AccountsController is defined.
Related issues
Fixes: #11866
Manual testing steps
mainand create a wallet with 3 accounts, select account 1selectedAccountin the AccountsController to undefined, re-run yarn watch and re-open appScreenshots/Recordings
Before
After
App is accessible again
Pre-merge author checklist
Pre-merge reviewer checklist