Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display staking transaction methods #12110

Merged
merged 13 commits into from
Nov 4, 2024
Merged

feat: display staking transaction methods #12110

merged 13 commits into from
Nov 4, 2024
+90 −38

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Oct 30, 2024 •
edited
Loading

Description

Display staking transaction methods in the transaction confirmation rather than Unknown Method.

Specifically:

  • Provide new TransactionType values in the addTransaction options.
  • Add action keys for staking transaction types.
  • Upgrade @metamask/transaction-controller to 38.2.0.

Related issues

Fixes: #2012

Manual testing steps

  1. Add export MM_POOLED_STAKING_UI_ENABLED="true" to .js.env.
  2. Create each staking transaction type.
  3. Verify method is correct and not Unknown Method.

Screenshots/Recordings

Before

Before

After

Deposit Claim Unstake Activity List

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0
Add types to staking transactions
5141d9b 
Upgrade Node to 20.17.
Use preview build of transaction controller.
@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Oct 30, 2024
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners October 30, 2024 21:00
@matthewwalsh0 matthewwalsh0 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 30, 2024
OGPoyraz
OGPoyraz reviewed Oct 31, 2024
View reviewed changes
.nvmrc Outdated Show resolved Hide resolved
OGPoyraz
OGPoyraz previously approved these changes Oct 31, 2024
View reviewed changes
@OGPoyraz OGPoyraz mentioned this pull request Oct 31, 2024
Merged
7 tasks
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3a82cb0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/df991c10-f5e8-4fa3-85dd-e0e891c99c43

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

amitabh94
amitabh94 previously approved these changes Oct 31, 2024
View reviewed changes
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6e208d8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/62e99960-b3c9-4954-bd24-100cf05702cd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@matthewwalsh0 matthewwalsh0 removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 26d8c09
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46d91810-16de-40bf-8d66-c068f1c51181

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

OGPoyraz
OGPoyraz previously approved these changes Nov 4, 2024
View reviewed changes
amitabh94
amitabh94 previously approved these changes Nov 4, 2024
View reviewed changes
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a3bf55e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e1ddb0aa-f595-4201-82f0-7ae973eeabe4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@matthewwalsh0 matthewwalsh0 dismissed stale reviews from vinistevam, amitabh94, and OGPoyraz via 13ebdcf November 4, 2024 16:46
@matthewwalsh0 matthewwalsh0 force-pushed the feat/staking-transaction-methods branch from a3bf55e to 13ebdcf Compare November 4, 2024 16:46
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 13ebdcf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4f72a24f-3ad7-4d47-9a7b-6eeb53136bf8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.6% Coverage on New Code
3.8% Duplication on New Code

See analysis details on SonarCloud

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 080a77b Nov 4, 2024
44 of 45 checks passed
@matthewwalsh0 matthewwalsh0 deleted the feat/staking-transaction-methods branch November 4, 2024 19:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@vinistevam vinistevam vinistevam approved these changes

@amitabh94 amitabh94 amitabh94 approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

Assignees
No one assigned
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matthewwalsh0 @OGPoyraz @amitabh94 @vinistevam @tommasini @metamaskbot