feat: Add re-simulation feature #12107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR aims to add re-simulation logic which recently added at MetaMask/core#4792 Patch note: Transaction controller patch adds the re-simulate feature, branched belove to keep track - this will eventually be removed in subsequent releases. MetaMask/core@main...patch/mobile-transaction-controller-35-0-0 Fixes: MetaMask/MetaMask-planning#3380 Since the changes are in the core - it's already validated in the extension in the transaction lifecycle. But for the sake of risk, all transaction simulations will be rechecked and approval will be needed from QA as we discussed internally. https://github.com/user-attachments/assets/42a433d0-7156-4f6d-b45b-fd6cdda712ee NA NA - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
github-actions
bot
added
the
team-confirmations
OGPoyraz
commented
Oct 31, 2024
OGPoyraz
force-pushed
the
feat/resimulate
branch
from
f910be1 to
af41bb4
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/base-controller@7.0.1, npm/@metamask/controller-utils@11.3.0 |
matthewwalsh0
previously approved these changes
Oct 31, 2024
matthewwalsh0
approved these changes
Oct 31, 2024
OGPoyraz
added
No QA Needed
|
pedronfigueiredo
approved these changes
Oct 31, 2024
tommasini
approved these changes
Oct 31, 2024
tommasini
added
the
skip-sonar-cloud
metamaskbot
added
the
release-7.35.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks #12073
Quality gate failures:
These are expected as we discussed - all those failures will be addressed in the https://github.com/MetaMask/MetaMask-planning/issues/3584
Node version update:
It's a side effect of the bump to
7.0.1of@metamask/rpc-errors.https://github.com/MetaMask/rpc-errors/blob/main/package.json#L92
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3380
Manual testing steps
Screenshots/Recordings
This feature already tested and released.
Please see the original picked PR for recording.
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist