-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Simulation re-trigger #12073
feat: Simulation re-trigger #12073
Conversation
app/components/Views/ChangeInSimulationModal/ChangeInSimulationModal.tsx
Show resolved
Hide resolved
app/components/Views/ChangeInSimulationModal/ChangeInSimulationModal.test.tsx
Outdated
Show resolved
Hide resolved
…nModal.test.tsx Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/7.33.1 #12073 +/- ##
=================================================
Coverage ? 53.99%
=================================================
Files ? 1647
Lines ? 38337
Branches ? 4672
=================================================
Hits ? 20699
Misses ? 16208
Partials ? 1430 ☔ View full report in Codecov by Sentry. |
Quality Gate failedFailed conditions |
Considering the manual test evidence. I am okay moving forward with an override. I would like to see an issue created to support modal unit testing for these scenarios. @OGPoyraz |
Bitrise builds: https://app.bitrise.io/build/4a80f97e-7cee-49ba-b0c0-d3b0e150ce5c?tab=log The fix has been implemented successfully. However, we experienced a challenge with the iOS build on Bitrise, which prevented testing the functionality on a physical device. Despite this, the local iOS build operates as anticipated. Screen_Recording_20241029_113830_MetaMask.mp4last.mp4In iOS Bitrise build all transaction action are disabled and other errors not related to the current PR are present as well, for example the error you get when trying to access networks modal: |
Description
This PR aims to add re-simulation logic which recently added at MetaMask/core#4792
Patch note:
Transaction controller patch adds the re-simulate feature, branched belove to keep track - this will eventually be removed in subsequent releases.
MetaMask/core@main...patch/mobile-transaction-controller-35-0-0
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3380
Manual testing steps
Since the changes are in the core - it's already validated in the extension in the transaction lifecycle.
But for the sake of risk, all transaction simulations will be rechecked and approval will be needed from QA as we discussed internally.
Screenshots/Recordings
Simulator.Screen.Recording.-.iPhone.13.Pro.-.2024-10-29.at.14.15.02.mp4
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist