-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hide internal transaction origins in confirmation views #12100
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: aeacbbb Note
|
TransactionHeader
and ApproveTransactionHeader
...ponents/Views/confirmations/components/ApproveTransactionHeader/ApproveTransactionHeader.tsx
Outdated
Show resolved
Hide resolved
...ts/Views/confirmations/components/ApproveTransactionHeader/ApproveTransactionHeader.test.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12100 +/- ##
==========================================
+ Coverage 55.35% 55.54% +0.19%
==========================================
Files 1767 1777 +10
Lines 39841 40043 +202
Branches 4965 4986 +21
==========================================
+ Hits 22052 22241 +189
- Misses 16274 16282 +8
- Partials 1515 1520 +5 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
Bitrise❌❌❌ Commit hash: af05fe0 Note
Tip
|
Bitrise❌❌❌ Commit hash: 8aa5929 Note
Tip
|
Bitrise❌❌❌ Commit hash: 00c0e85 Note
Tip
|
Quality Gate passedIssues Measures |
Description
This PR modifies the transaction confirmation flow to hide the origin display when transactions are generated internally by the wallet.
Changes
TransactionHeader
andApproveTransactionHeader
components to conditionally render origin informationRelated issues
Fixes: #11919
Manual testing steps
Case 1
Confirm
Case 2
Set Approve for All
Screenshots/Recordings
Before
After
origin.pill.webm
Pre-merge author checklist
Pre-merge reviewer checklist