Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide internal transaction origins in confirmation views #12100

Merged
merged 12 commits into from
Nov 5, 2024

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Oct 30, 2024

Description

This PR modifies the transaction confirmation flow to hide the origin display when transactions are generated internally by the wallet.
Changes

  • Updated TransactionHeader and ApproveTransactionHeader components to conditionally render origin information
  • Added logic to identify internal origins.

Related issues

Fixes: #11919

Manual testing steps

Case 1

  1. Import a QR account
  2. Go to test dapp
  3. Perform a signature or transaction
  4. and click Confirm

Case 2

  1. Normal account , go to the test-dapp
  2. Click Set Approve for All

Screenshots/Recordings

Before

before

After

after
origin.pill.webm

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Oct 30, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam marked this pull request as ready for review October 30, 2024 10:04
@vinistevam vinistevam requested review from a team as code owners October 30, 2024 10:04
@vinistevam vinistevam added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: aeacbbb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b8a63b0e-8549-45fc-8dff-a8a87e4ff553

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 30, 2024
@vinistevam vinistevam changed the title fix: hide origin for TransactionHeader and ApproveTransactionHeader fix: hide internal transaction origins in confirmation views Oct 30, 2024
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.54%. Comparing base (ead35c4) to head (2b9fc4c).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12100      +/-   ##
==========================================
+ Coverage   55.35%   55.54%   +0.19%     
==========================================
  Files        1767     1777      +10     
  Lines       39841    40043     +202     
  Branches     4965     4986      +21     
==========================================
+ Hits        22052    22241     +189     
- Misses      16274    16282       +8     
- Partials     1515     1520       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 30, 2024
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Nov 4, 2024
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 4, 2024
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 4, 2024
@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: af05fe0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07db2000-3f61-4280-9a61-61d7a8d26dd7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8aa5929
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9f78d42e-e7d4-46be-8235-523b3389e875

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 00c0e85
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/65aad873-5e3d-4e6e-8aca-a8fd267c71ba

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarqubecloud bot commented Nov 5, 2024

@MetaMask MetaMask deleted a comment from github-actions bot Nov 5, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Nov 5, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Nov 5, 2024
@vinistevam vinistevam added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 7fb3bda Nov 5, 2024
42 of 43 checks passed
@vinistevam vinistevam deleted the fix/hide-origin-transaction-header branch November 5, 2024 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide origin in transaction confirmation if origin is internal
6 participants