Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide origin in transaction confirmation if origin is internal #11919

Closed
9 tasks
matthewwalsh0 opened this issue Oct 21, 2024 · 0 comments · Fixed by #12100
Closed
9 tasks

Hide origin in transaction confirmation if origin is internal #11919

matthewwalsh0 opened this issue Oct 21, 2024 · 0 comments · Fixed by #12100
Assignees
@vinistevam
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 team-confirmations Push issues to confirmations team

Comments

@matthewwalsh0
Copy link
Member

What is this about?

Ensure transaction confirmations do not display the origin of the transaction metadata if the transaction was generated from the wallet.

Scenario

No response

Design

No response

Technical Details

  • Update TransactionHeader component.
  • Consider handling all internal origins in mobile, currently TransactionTypes.MMM, process.env.FOX_CODE and ORIGIN_METAMASK.
  • Verify no other origin display components.

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Oct 21, 2024
@vinistevam vinistevam self-assigned this Oct 29, 2024
@vinistevam vinistevam mentioned this issue Oct 30, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 5, 2024
@vinistevam @matthewwalsh0
fix: hide internal transaction origins in confirmation views (#12100)
7fb3bda 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
This PR modifies the transaction confirmation flow to hide the origin
display when transactions are generated internally by the wallet.
**Changes**
- Updated `TransactionHeader` and `ApproveTransactionHeader` components
to conditionally render origin information
- Added logic to identify internal origins.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #11919

## **Manual testing steps**

**Case 1**
1. Import a QR account
2. Go to test dapp
3. Perform a signature or transaction
4. and click `Confirm`

**Case 2**
1. Normal account , go to the test-dapp
2. Click `Set Approve for All`

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img
src="https://github.com/user-attachments/assets/0ae320e9-4f11-4f7d-9237-57b8442a1683"
alt="before" width="400"/>


<!-- [screenshots/recordings] -->

### **After**

<img
src="https://github.com/user-attachments/assets/b31254cf-0e91-401d-bdc0-c4afec979437"
alt="after" width="400"/>

[origin
pill.webm](https://github.com/user-attachments/assets/b15f2732-efc6-40cb-8a94-7dcae1e1b20e)


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 5, 2024
vinistevam added a commit that referenced this issue Nov 5, 2024
@vinistevam @matthewwalsh0
fix: hide internal transaction origins in confirmation views (#12100)
6bc92b3 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
This PR modifies the transaction confirmation flow to hide the origin
display when transactions are generated internally by the wallet.
**Changes**
- Updated `TransactionHeader` and `ApproveTransactionHeader` components
to conditionally render origin information
- Added logic to identify internal origins.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #11919

## **Manual testing steps**

**Case 1**
1. Import a QR account
2. Go to test dapp
3. Perform a signature or transaction
4. and click `Confirm`

**Case 2**
1. Normal account , go to the test-dapp
2. Click `Set Approve for All`

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img
src="https://github.com/user-attachments/assets/0ae320e9-4f11-4f7d-9237-57b8442a1683"
alt="before" width="400"/>


<!-- [screenshots/recordings] -->

### **After**

<img
src="https://github.com/user-attachments/assets/b31254cf-0e91-401d-bdc0-c4afec979437"
alt="after" width="400"/>

[origin
pill.webm](https://github.com/user-attachments/assets/b15f2732-efc6-40cb-8a94-7dcae1e1b20e)


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
@vinistevam vinistevam mentioned this issue Nov 5, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinistevam vinistevam

Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: hide internal transaction origins in confirmation views MetaMask/metamask-mobile
3 participants
@matthewwalsh0 @metamaskbot @vinistevam