Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert sentry traces #11862

Merged
merged 4 commits into from
Oct 18, 2024
Merged

chore: revert sentry traces #11862

merged 4 commits into from
Oct 18, 2024

Conversation

tommasini
Copy link
Contributor

Description

revert this PR

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements) labels Oct 18, 2024
@tommasini tommasini requested review from a team as code owners October 18, 2024 10:24
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 54.49%. Comparing base (b0ef1a7) to head (376491f).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
app/components/Views/Onboarding/index.js 0.00% 7 Missing ⚠️
app/components/Views/Login/index.js 0.00% 2 Missing ⚠️
app/components/Nav/App/index.js 0.00% 1 Missing ⚠️
app/components/Views/LockScreen/index.js 0.00% 1 Missing ⚠️
app/store/index.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11862      +/-   ##
==========================================
+ Coverage   54.27%   54.49%   +0.22%     
==========================================
  Files        1711     1741      +30     
  Lines       38712    39252     +540     
  Branches     4738     4860     +122     
==========================================
+ Hits        21010    21392     +382     
- Misses      16253    16366     +113     
- Partials     1449     1494      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 376491f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a938660b-91bd-4ec1-9d54-e566618a5c8b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

MarioAslau
MarioAslau previously approved these changes Oct 18, 2024
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart NicolasMassart added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
NicolasMassart
NicolasMassart previously approved these changes Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8302878
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f7f1ce50-88bc-499e-8dd0-c9bec806dcee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini dismissed stale reviews from NicolasMassart and MarioAslau via a6b79ca October 18, 2024 15:35
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a6b79ca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c535c249-0c26-4f9e-8f69-d2c314742d4b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit bf5bb97 Oct 18, 2024
43 checks passed
@tommasini tommasini deleted the chore/revert-traces-sentry branch October 18, 2024 16:29
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants