Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1940 Add custom traces #11579

Merged
merged 20 commits into from
Oct 15, 2024
Merged

feat: 1940 Add custom traces #11579

merged 20 commits into from
Oct 15, 2024

Conversation

MarioAslau
Copy link
Contributor

@MarioAslau MarioAslau commented Oct 2, 2024

Description

Screenshot 2024-10-11 at 20 29 04 Screenshot 2024-10-16 at 00 01 02 Screenshot 2024-10-15 at 17 57 12

This task is for adding custom spans to track activities that happen between app start and wallet UI load. The screenshot below is an example of a trace for Wallet UI load that takes about a minute to load. During that time, we can see a large gap between app start spans and the initial http requests.

The goal here is to isolate these areas and track them with custom spans. Once implemented, we can expect to see the custom spans appearing within the gap, which would inform us of the areas to optimize

Issue: https://github.com/MetaMask/mobile-planning/issues/1940

Technical Details

  • Added custom span for when the Login screen is mounted to when the login button is tapped
  • Added span for when the login button is tapped to when the wallet view is mounted
  • Added custom span for Engine initialization process
  • Added custom span for Store creation
  • Added custom span Storage rehydration
  • Added custom span fro Create New Wallet to Choose Password
  • Added custom span for Biometrics authentication

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MarioAslau MarioAslau added team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements) labels Oct 2, 2024
@MarioAslau MarioAslau self-assigned this Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MarioAslau MarioAslau requested review from Cal-L and tommasini October 2, 2024 18:55
@MarioAslau
Copy link
Contributor Author

We are waiting to have a meeting with a Sentry representative to clarify some questions that we have, before merging this

@gauthierpetetin gauthierpetetin added the area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. label Oct 9, 2024
@MarioAslau MarioAslau marked this pull request as ready for review October 15, 2024 15:05
@MarioAslau MarioAslau requested review from a team as code owners October 15, 2024 15:05
@MarioAslau MarioAslau added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c13b801
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9d956e93-49cd-4658-91da-d5e2c9403e3e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b1f17cb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d53febd-7fa5-4764-b693-0e0367640f09

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sethkfman
sethkfman previously approved these changes Oct 15, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 15, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 2e8439b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cba7e6eb-6385-4324-af00-6364e1585ea4

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 13f7674
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f8f40593-e399-48a4-9c4c-32991421af4c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@MarioAslau MarioAslau requested a review from sethkfman October 15, 2024 22:22
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman enabled auto-merge October 15, 2024 22:27
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sethkfman sethkfman added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 9ac1488 Oct 15, 2024
43 checks passed
@sethkfman sethkfman deleted the feat/1940-add-custom-sentry-span branch October 15, 2024 22:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@sethkfman sethkfman added release-7.33.0 Issue or pull request that will be included in release 7.33.0 and removed release-7.34.0 labels Oct 16, 2024
@MarioAslau MarioAslau restored the feat/1940-add-custom-sentry-span branch October 22, 2024 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants