-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1940 Add custom traces #11579
feat: 1940 Add custom traces #11579
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
We are waiting to have a meeting with a Sentry representative to clarify some questions that we have, before merging this |
Bitrise✅✅✅ Commit hash: c13b801 Note
|
…/MetaMask/metamask-mobile into feat/1940-add-custom-sentry-span
Bitrise✅✅✅ Commit hash: b1f17cb Note
|
…/MetaMask/metamask-mobile into feat/1940-add-custom-sentry-span
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bitrise🔄🔄🔄 Commit hash: 2e8439b Note
|
…/MetaMask/metamask-mobile into feat/1940-add-custom-sentry-span
Bitrise✅✅✅ Commit hash: 13f7674 Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This task is for adding custom spans to track activities that happen between app start and wallet UI load. The screenshot below is an example of a trace for Wallet UI load that takes about a minute to load. During that time, we can see a large gap between app start spans and the initial http requests.
The goal here is to isolate these areas and track them with custom spans. Once implemented, we can expect to see the custom spans appearing within the gap, which would inform us of the areas to optimize
Issue: https://github.com/MetaMask/mobile-planning/issues/1940
Technical Details
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist