chore: cherry-pick #11595 #11683
Merged
chore: cherry-pick #11595 #11683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR fixes an issue where the `Signature Requested` mobile analytics event was not being sent when a dapp sends a sign request. Only the `Signature Approved` analytics where being sent. Examples: From [MetaMask SDK Wagmi test dapp](https://mmsdk-wagmi-test-dapp.vercel.app) (mobile browser): ``` {"event": "Signature Requested", "properties": {"account_type": "MetaMask", "chain_id": "11155111", "dapp_host_name": "wagmi.io", "request_platform": "web-mobile", "request_source": "MetaMask-SDK-Remote-Conn", "signature_type": "personal_sign", "version": "N/A"}, "type": "track"} ``` From [WalletConnect test dapp](https://appkit-lab.reown.com) (mobile browser): ``` {"event": "Signature Requested", "properties": {"account_type": "MetaMask", "chain_id": "11155111", "dapp_host_name": "appkit-lab.reown.com", "request_platform": undefined, "request_source": "WalletConnect", "signature_type": "eth_signTypedData_v4", "version": "N/A"}, "type": "track"} ``` From iOS SDK test dapp: ``` {"event": "Signature Requested", "properties": {"account_type": "MetaMask", "chain_id": "11155111", "dapp_host_name": "dubdapp.com", "request_platform": "ios", "request_source": "MetaMask-SDK-Remote-Conn", "signature_type": "eth_signTypedData_v4", "version": "N/A"}, "type": "track"} ``` ## **Related issues** Fixes: [SDK-65](https://consensyssoftware.atlassian.net/browse/SDK-65) ## **Manual testing steps** 1. Go to this [mmsdk-wagmi-test-dapp](https://mmsdk-wagmi-test-dapp.vercel.app/) on mobile device 2. Connect to MetaMask 3. Sign message 4. Check the logs that `Signature Requested` is being logged to analytics and also check Segment that the event is being received. ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [SDK-65]: https://consensyssoftware.atlassian.net/browse/SDK-65?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
elefantel
approved these changes
Oct 8, 2024
darkwing
approved these changes
Oct 8, 2024
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
NicolasMassart
added
Run Smoke E2E
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks #11595