fix: fix signature requested analytics #11595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the
Signature Requested
mobile analytics event was not being sent when a dapp sends a sign request. Only theSignature Approved
analytics where being sent.Examples:
From MetaMask SDK Wagmi test dapp (mobile browser):
From WalletConnect test dapp (mobile browser):
From iOS SDK test dapp:
Related issues
Fixes: SDK-65
Manual testing steps
Signature Requested
is being logged to analytics and also check Segment that the event is being received.Pre-merge author checklist
Pre-merge reviewer checklist