-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added ReactNode support for KeyValueRow tooltip and label #11660
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
8f5170a
to
e378716
Compare
e378716
to
da8b99a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Approving to unblock but @brianacnguyen may be a better resource for review.
Quality Gate passedIssues Measures |
Bitrise❌❌❌ Commit hash: b126022 Note
Tip
|
Description
Iterates on the
<KeyValueRow />
component by addingReactNode
support for tooltip content and label. This should allow for greater flexibility using<KeyValueRow />
.Related issues
These are prerequisite changes needed in mobile native staking tickets. (e.g. STAKE-824: [FE] Build staking input confirmation screen)
Manual testing steps
<KeyValueRow />
inside of components-temp directoryScreenshots/Recordings
Before
Missing bottom example using ReactNode (Button Link)
After
Has bottom example that's using ReactNode (Button Link)
Pre-merge author checklist
Pre-merge reviewer checklist