-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: STAKE-824: [FE] build staking input confirmation screen #11605
feat: STAKE-824: [FE] build staking input confirmation screen #11605
Conversation
…input-review-bottom-sheet-component
…input-review-bottom-sheet-component
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
63ddf21
to
a66d609
Compare
…racting with section to match latest designs
…staking-input-confirmation-screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Bitrise✅✅✅ Commit hash: ea4211b Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change AmountHeader
to another name to reduce confusions
Bitrise✅✅✅ Commit hash: 9379b1a Note
|
Quality Gate passedIssues Measures |
Approved, though I'd suggest to update the AccountHeaderCard to not include Header |
Description
This PR adds the staking confirmation screen with some mock data being used temporarily.
Change List
<StakeInputView />
to staking confirmation screen when user enters valid amount to stake.Related issues
Ticket: [FE] Build staking input confirmation screen - (link)
Figma Designs - link
Manual testing steps
export MM_POOLED_STAKING_UI_ENABLED=true
to your.js.env
file.wETH
and Fiat.Screenshots/Recordings
Before
Nothing would happen after clicking "Confirm" on the stake input view. This screen is new.
After
stake-824-build-stake-confirmation-screen-after.mov
Pre-merge author checklist
Pre-merge reviewer checklist