Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-ts): Convert app/components/UI/Swaps/components/InfoModal.js to TypeScript #11650

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 7, 2024

This PR converts the InfoModal.js file to TypeScript (InfoModal.tsx) in the Swaps component and deletes the original JavaScript file.

Changes made:

  • Converted InfoModal.js to InfoModal.tsx
  • Added TypeScript types for props and other variables
  • Updated imports and component structure to follow TypeScript conventions
  • Deleted the original InfoModal.js file

Link to Devin run: https://preview.devin.ai/devin/d66629e78f134b0daa3e306ab4a2b05e

This PR is a re-creation of the previously closed PR #11597 with the same changes, focusing only on the InfoModal.tsx file as requested.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested review from a team as code owners October 7, 2024 07:41
Copy link
Contributor

github-actions bot commented Oct 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Oct 7, 2024
@devin-ai-integration devin-ai-integration bot added js-ts-conversion Conversion from JavaScript to TypeScript No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed js-ts-conversion Conversion from JavaScript to TypeScript labels Oct 7, 2024
Copy link

sonarqubecloud bot commented Oct 7, 2024

Copy link
Contributor

@smilingkylan smilingkylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smilingkylan smilingkylan added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
Copy link
Contributor

@smilingkylan smilingkylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smilingkylan smilingkylan added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit efba253 Oct 10, 2024
37 checks passed
@smilingkylan smilingkylan deleted the devin/convert-ts-InfoModal-redux branch October 10, 2024 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ai AI team (for the Devin AI bot)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants