chore(js-ts): Convert app/components/UI/Swaps/components/InfoModal.js to TypeScript #11597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…and Theme['shadows']
devin-ai-integration
bot
added
No QA Needed
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Causing our Typescript linter to fail with the following error. Essentially, by setting |
|
After looking into it, the line causing the issue was last modified 18 months ago so I don't think it's because of any marge-like sequence. |
|
github-actions
bot
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Title
chore(js-ts): Convert app/components/UI/Swaps/components/InfoModal.js to TypeScript
Description
This PR converts the
InfoModal.jsfile to TypeScript. The conversion involved renaming the file toInfoModal.tsx, defining prop types using TypeScript interfaces, and removing thepropTypessection. TheuseThemehook was used to determine the types forcolorsandshadows.Related Issues
N/A
Manual Testing Steps
InfoModalcomponent renders correctly in the application.InfoModalcomponent works as expected.InfoModalcomponent.Author Checklist
InfoModal.jsto TypeScript.propTypesand replaced them with TypeScript interfaces.yarn lintandyarn lint:tsccomplete without errors.Reviewer Checklist
InfoModalcomponent functions correctly.InfoModalcomponent.This Devin run was requested by naveen.
If you have any feedback, you can leave comments in the PR and I'll address them in the app!