-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ramp): improve amount editing formatting #11613
Conversation
Bitrise✅✅✅ Commit hash: cde58c7 Note
|
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
Description
This PR improves the changes introduced in #9039, which formatted the amount input on-the-fly as the user typed it for better readability (
123456.78
to123,456.78
). However the formatting was introducing an unexpected state when the user typed the decimal separator (See Before video).This PR brings back the full formatting when the user has finishing editing the amount. While editing, the amount will be grouped in 3 chars separated by space to improve readability of the input.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
When decimal separator is typed, the amount remains unchanged.
When deleting the decimal separator, the amount remains unchanged.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-03.at.14.10.18.mp4
After
The amount represents every state of the amount change, even partial ones lile
1234.
or1234.0
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-03.at.14.08.39.mp4
Pre-merge author checklist
Pre-merge reviewer checklist