-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ramp): persist and format amount in build quote view #9039
refactor(ramp): persist and format amount in build quote view #9039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Bitrise✅✅✅ Commit hash: 89fec7f Note
|
@wachunei LGTM I verified the buy and sell flows ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9039 +/- ##
==========================================
- Coverage 45.54% 45.53% -0.01%
==========================================
Files 1272 1272
Lines 31236 31232 -4
Branches 3188 3187 -1
==========================================
- Hits 14225 14221 -4
Misses 16171 16171
Partials 840 840 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Description
This PR makes the following changes:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1465
Manual testing steps
Screenshots/Recordings
Before
amount_before.mp4
After
amount_after.mp4
Pre-merge author checklist
Pre-merge reviewer checklist