Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert chore(js-ts): Migrate 37 0-error js files #11418

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Sep 24, 2024

Description

The purpose of this PR is to revert #11214

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 24, 2024
@cortisiko cortisiko self-assigned this Sep 24, 2024
@cortisiko cortisiko requested review from a team as code owners September 24, 2024 17:58
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

github-actions bot commented Sep 24, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 85c0fbf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fd583a4a-f053-4f85-b207-f877763894a5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko enabled auto-merge September 24, 2024 18:28
@cortisiko cortisiko disabled auto-merge September 24, 2024 18:34
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cortisiko cortisiko enabled auto-merge September 24, 2024 18:43
Copy link

@cortisiko cortisiko added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 0fcd118 Sep 24, 2024
36 checks passed
@cortisiko cortisiko deleted the revert-11214 branch September 24, 2024 19:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2024
@metamaskbot metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants