-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(js-ts): Migrate 37 0-error js files #11214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reen.ts as it does not use JSX syntax
….ts as it does not use JSX syntax
…as it does not use JSX syntax
… not use JSX syntax
…ot use JSX syntax
devin-ai-integration
bot
changed the title
chore: Refactor JavaScript Files to TypeScript
chore(js-ts): Migrate 37 0-error js files
Sep 15, 2024
Quality gate failures can be ignored since this is just renaming |
Cal-L
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sethkfman
added
the
No QA Needed
Apply this label when your PR does not need any QA effort.
label
Sep 18, 2024
Quality Gate passedIssues Measures |
metamaskbot
added
the
release-7.33.0
Issue or pull request that will be included in release 7.33.0
label
Sep 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No QA Needed
Apply this label when your PR does not need any QA effort.
release-7.33.0
Issue or pull request that will be included in release 7.33.0
team-ai
AI team (for the Devin AI bot)
team-mobile-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Refactor JavaScript Files to TypeScript
Description
This pull request completes the task of refactoring JavaScript files to TypeScript in the metamask-mobile repository. The changes involve renaming .js files to .ts or .tsx based on the presence of JSX syntax, and making necessary adjustments for TypeScript compatibility.
Changes Made
Files Affected
The refactoring covered various types of components and utilities, including:
For a complete list of refactored files, please refer to the diff.
Snapshot Files Renamed
The following snapshot files were renamed from .test.js.snap to .test.tsx.snap:
This renaming was done to maintain consistency with the recent refactoring of JavaScript files to TypeScript.
Important Notes for Reviewers
Testing
Next Steps
Checklist
Please review and provide any feedback. Thank you!