-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(1702-2): auto detect nft component #11364
refactor(1702-2): auto detect nft component #11364
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise🔄🔄🔄 Commit hash: 2681a9b Note
|
Bitrise🔄🔄🔄 Commit hash: 89ccef2 Note
|
Bitrise✅✅✅ Commit hash: aa3535a Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR is part of a series that breaks down the original large PR #11127 into smaller, more manageable chunks.
The
AutoDetectNFTSettings
functionality is valuable beyond its original implementation. By converting it into a reusable component, we can:Changes
AutoDetectNFTSettings
logic from its original locationSecuritySettings
and into a separate component fileSecuritySettings
to use the new componentSecuritySettings
and moved them into the new component folderImpact
This refactored component will be used in:
SecuritySettings
Related issues
Feature: #1702
Manual testing steps
Screenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist