-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(1702): enhanced onboarding settings config #11127
feat(1702): enhanced onboarding settings config #11127
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
13317a7
to
08234ab
Compare
…screen and security screen. Assets is in progress as well as testing/snaps/etc
…ct nft, enhanced token detection, and IPFS gateway
2aaea6c
to
92e2f3a
Compare
Bitrise✅✅✅ Commit hash: 94fa19b Note
|
…1702-enhance-onboarding-settings-config
Bitrise✅✅✅ Commit hash: edbb82e Note
|
Decided to postpone refactoring the Advanced Security Settings component into TS in favor of Q4 objectives
Bitrise🔄🔄🔄 Commit hash: 1cdd534 Note
|
Bitrise🔄🔄🔄 Commit hash: cdbc16d Note
|
Bitrise🔄🔄🔄 Commit hash: bb29b36 Note
|
Bitrise✅✅✅ Commit hash: 7808d51 Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great use of design system components, excellent PR description and the PR size is much more manageable. Removing additional styling also improves consistency, in my opinion. Nice work! 💯 I didn't run locally so please get review from the other listed reviewers with mobile focus before merging 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work on improving user experience.
Description
This PR enhances the onboarding experience by allowing users to configure key settings before accessing their wallet. This change aims to improve user control and understanding of the app's features from the outset. Some copy was also added or changed
New Screens
Added the following screens to the
OnboardingSuccessFlow
:OnboardingGeneralSettings
OnboardingAssetsSettings
OnboardingSecuritySettings
Related issues
Feature: #1702
Manual testing steps
Screenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist