Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix check token balance is zero #11172

Merged

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Sep 12, 2024

Description

When the setting to hide tokens when is zero is ON, we should not be able to see zero balances on tokens tab.

Related issues

Fixes:
#11072
https://github.com/MetaMask/mobile-planning/issues/1869

Manual testing steps

  1. Click on setting => General and enable setting: Hide tokens without balance
  2. Go to tokens tab and import any token that you do not have balance for
  3. Check that you do not see the imported token on the main page

Screenshots/Recordings

Before

Screen.Recording.2024-09-12.at.13.15.48.mov

After

Screen.Recording.2024-09-12.at.13.09.37.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner September 12, 2024 11:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Sep 12, 2024
@sahar-fehri sahar-fehri self-assigned this Sep 12, 2024
@Andepande Andepande added the Run Smoke E2E Triggers smoke e2e on Bitrise label Sep 12, 2024
Copy link
Contributor

github-actions bot commented Sep 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 120415f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1207c1a-3457-4ee8-b523-e79cb07e2815

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Andepande Andepande added the QA Passed A successful QA run through has been done label Sep 12, 2024
Copy link

@sahar-fehri sahar-fehri merged commit 02a9cd3 into main Sep 12, 2024
38 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-hide-tokens-with-zero-balance-when-setting-is-on branch September 12, 2024 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. QA Passed A successful QA run through has been done release-7.32.0 Issue or pull request that will be included in release 7.32.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants