Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: "Hide Tokens without Balance" toggle does not hide tokens with 0 balance on the main wallet view #11072

Closed
Andepande opened this issue Sep 5, 2024 · 0 comments
Closed

[Bug]: "Hide Tokens without Balance" toggle does not hide tokens with 0 balance on the main wallet view #11072

Andepande opened this issue Sep 5, 2024 · 0 comments
Assignees
@sahar-fehri
Labels
regression-prod-7.30.0 Regression bug that was found in production in release 7.30.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working

Comments

@Andepande
Copy link
Member

Andepande commented Sep 5, 2024 •
edited
Loading

Describe the bug

When the "Hide Tokens without Balance" toggle is enabled, tokens with a 0 balance are still visible in the main wallet view.

Expected behavior

Tokens with a 0 balance should be hidden on the main wallet view

Screenshots/Recordings

image

PHOTO-2024-09-12-10-47-49

Steps to reproduce

  1. Open the wallet.
  2. Ensure there are tokens with a 0 balance visible in the main wallet view.
  3. Enable the "Hide Tokens without Balance" toggle.
  4. Observe that tokens with a 0 balance are still shown.

Error messages or log output

No response

Detection stage

In production (default)

Version

7.30.0

Build type

Other (please specify exactly where you obtained this build in "Additional Context" section)

Device

IOS & Android

Operating system

iOS, Android

Additional context

No response

Severity

sev2
@Andepande Andepande added type-bug Something isn't working needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Sep 5, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Sep 5, 2024
@Andepande Andepande added team-assets and removed needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Sep 5, 2024
@metamaskbot metamaskbot added the regression-prod-7.30.0 Regression bug that was found in production in release 7.30.0 label Sep 5, 2024
@Andepande Andepande added Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking and removed regression-prod-7.30.0 Regression bug that was found in production in release 7.30.0 labels Sep 5, 2024
@metamaskbot metamaskbot added the regression-prod-7.30.0 Regression bug that was found in production in release 7.30.0 label Sep 5, 2024
@sahar-fehri sahar-fehri mentioned this issue Sep 12, 2024
Merged
7 tasks
@sahar-fehri sahar-fehri self-assigned this Sep 12, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Sep 12, 2024
runway-github bot added a commit that referenced this issue Sep 12, 2024
@runway-github @tommasini
temp+fix: fix check token balance is zero (#11172)
373d426 
## **Description**

When the setting to hide tokens when is zero is ON, we should not be
able to see zero balances on tokens tab.

## **Related issues**

Fixes:
#11072
https://github.com/MetaMask/mobile-planning/issues/1869

## **Manual testing steps**

1. Click on setting => General and enable setting: Hide tokens without
balance
2. Go to tokens tab and import any token that you do not have balance
for
3. Check that you do not see the imported token on the main page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/user-attachments/assets/1d18de27-90ca-4e10-9ca6-9b834d94a323




### **After**



https://github.com/user-attachments/assets/1c58346b-45a6-4b31-ab26-f82795d6aeda



## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
runway-github bot added a commit that referenced this issue Sep 12, 2024
@runway-github @tommasini
temp+fix: fix check token balance is zero (#11172)
226e306 
## **Description**

When the setting to hide tokens when is zero is ON, we should not be
able to see zero balances on tokens tab.

## **Related issues**

Fixes:
#11072
https://github.com/MetaMask/mobile-planning/issues/1869

## **Manual testing steps**

1. Click on setting => General and enable setting: Hide tokens without
balance
2. Go to tokens tab and import any token that you do not have balance
for
3. Check that you do not see the imported token on the main page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

https://github.com/user-attachments/assets/1d18de27-90ca-4e10-9ca6-9b834d94a323

### **After**

https://github.com/user-attachments/assets/1c58346b-45a6-4b31-ab26-f82795d6aeda

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
runway-github bot pushed a commit that referenced this issue Sep 12, 2024
@sahar-fehri @tommasini
chore(runway): cherry-pick fix: fix check token balance is zero (#11172)
62cfa23 
## **Description**

When the setting to hide tokens when is zero is ON, we should not be
able to see zero balances on tokens tab.

## **Related issues**

Fixes:
#11072
MetaMask/mobile-planning#1869

## **Manual testing steps**

1. Click on setting => General and enable setting: Hide tokens without
balance
2. Go to tokens tab and import any token that you do not have balance
for
3. Check that you do not see the imported token on the main page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/user-attachments/assets/1d18de27-90ca-4e10-9ca6-9b834d94a323




### **After**



https://github.com/user-attachments/assets/1c58346b-45a6-4b31-ab26-f82795d6aeda



## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
@runway-github runway-github bot mentioned this issue Sep 12, 2024
Merged
7 tasks
sethkfman added a commit that referenced this issue Sep 13, 2024
@runway-github @sahar-fehri
@tommasini @sethkfman
chore(runway): cherry-pick fix: fix check token balance is zero (#11181)
22421bc 
- fix: fix check token balance is zero (#11172)

## **Description**

When the setting to hide tokens when is zero is ON, we should not be
able to see zero balances on tokens tab.

## **Related issues**

Fixes:
#11072
https://github.com/MetaMask/mobile-planning/issues/1869

## **Manual testing steps**

1. Click on setting => General and enable setting: Hide tokens without
balance
2. Go to tokens tab and import any token that you do not have balance
for
3. Check that you do not see the imported token on the main page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**



https://github.com/user-attachments/assets/1d18de27-90ca-4e10-9ca6-9b834d94a323




### **After**




https://github.com/user-attachments/assets/1c58346b-45a6-4b31-ab26-f82795d6aeda



## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding

Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
[02a9cd3](02a9cd3)

---------

Co-authored-by: sahar-fehri <sahar.fehri@consensys.net>
Co-authored-by: tommasini <46944231+tommasini@users.noreply.github.com>
Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sahar-fehri sahar-fehri

Labels
regression-prod-7.30.0 Regression bug that was found in production in release 7.30.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sahar-fehri @metamaskbot @Andepande