chore(deps): Bump `@metamask/smart-transactions-controller` from `11.0.0` to `^13.0.0` #11140

MajorLift · 2024-09-10T18:23:31Z

Description

Bump @metamask/smart-transactions-controller from 11.0.0 to ^13.0.0

Related issues

Fixes: #11047

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-10T18:23:43Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-09-10T18:24:45Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/smart-transactions-controller@13.0.0	network	`0`	195 kB	metamaskbot

🚮 Removed packages: npm/@metamask/smart-transactions-controller@11.0.0

View full report↗︎

…n mismatches - These are because mobile's base-controller version is now ahead of the version used in the controllers - These will be removed during the controller upgrades

github-actions · 2024-09-19T22:05:33Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 6b2fd98
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1475dbe5-db1f-42d6-9a68-5ceebcf12790

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-09-19T22:14:59Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9be130a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e1b5c91d-170f-480e-befb-7c29ca9dd538

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

app/util/smart-transactions/smart-publish-hook.ts

tommasini

LGTM! Would like the eyes of @infiniteflower or someone from the transactions team!

…art-transactions-controller-13.0.0

…ller-13.0.0

github-actions · 2024-09-20T18:53:29Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ef72a30
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/869f00da-3b43-4637-9819-a1cc341a8f61

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…art-transactions-controller-13.0.0

github-actions · 2024-09-20T20:29:56Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cc44b52
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/679a5929-645a-4930-8602-af0eb141ef6e

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2024-09-20T20:39:35Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
45.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MajorLift added the team-wallet-framework label Sep 10, 2024

MajorLift self-assigned this Sep 10, 2024

MajorLift added the team-transactions Transactions team label Sep 10, 2024

MajorLift force-pushed the jongsun/fix-composable-controller branch from 39bcf98 to 5f0eec9 Compare September 11, 2024 19:40

MajorLift mentioned this pull request Sep 11, 2024

chore(deps): Bump @metamask/composable-controller from ^3.0.0 to ^10.0.0 #10441

Merged

7 tasks

MajorLift force-pushed the jongsun/fix-composable-controller branch 3 times, most recently from 058687b to b4bfd59 Compare September 12, 2024 06:48

MajorLift added DO-NOT-MERGE Pull requests that should not be merged needs-smoke-e2e labels Sep 12, 2024

MajorLift force-pushed the jongsun/fix-composable-controller branch from b4bfd59 to 69970ad Compare September 12, 2024 07:02

MajorLift requested a review from a team September 12, 2024 08:02

MajorLift force-pushed the jongsun/chore/bump/smart-transactions-controller-13.0.0 branch from 8e48191 to 0bb5092 Compare September 12, 2024 08:03

MajorLift changed the base branch from jongsun/fix-composable-controller to jongsun/test/240911-e2e-fixes-for-10441 September 12, 2024 09:21

MajorLift force-pushed the jongsun/chore/bump/smart-transactions-controller-13.0.0 branch from 0bb5092 to e86ae9d Compare September 12, 2024 09:21

MajorLift force-pushed the jongsun/test/240911-e2e-fixes-for-10441 branch from 4cfa4c0 to 393ff53 Compare September 12, 2024 09:55

MajorLift force-pushed the jongsun/chore/bump/smart-transactions-controller-13.0.0 branch from e86ae9d to 229eb5f Compare September 12, 2024 11:09

MajorLift force-pushed the jongsun/test/240911-e2e-fixes-for-10441 branch from 393ff53 to 05ba0ff Compare September 12, 2024 15:11

MajorLift force-pushed the jongsun/chore/bump/smart-transactions-controller-13.0.0 branch from 65cd5f0 to a4cad2e Compare September 12, 2024 15:19

desi assigned cryptodev-2s Sep 12, 2024

MajorLift removed the team-transactions Transactions team label Sep 13, 2024

MajorLift requested a review from a team September 13, 2024 05:02

MajorLift force-pushed the jongsun/test/240911-e2e-fixes-for-10441 branch from 05ba0ff to 8436cc3 Compare September 13, 2024 05:05

MajorLift force-pushed the jongsun/chore/bump/smart-transactions-controller-13.0.0 branch from a4cad2e to b9370f3 Compare September 13, 2024 05:06

MajorLift force-pushed the jongsun/test/240911-e2e-fixes-for-10441 branch from 9be6c47 to bb38098 Compare September 13, 2024 13:15

MajorLift force-pushed the jongsun/chore/bump/smart-transactions-controller-13.0.0 branch from b9370f3 to 6abc772 Compare September 13, 2024 13:20

MajorLift added 2 commits September 13, 2024 15:55

Bump @metamask/base-controller from ^6.0.0 to ^7.0.0

d233289

Add temporary ts-expect-error directives for base-controller versio…

779ee0b

…n mismatches - These are because mobile's base-controller version is now ahead of the version used in the controllers - These will be removed during the controller upgrades

fix: remove forgotten console log

9be130a

cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 19, 2024

tommasini reviewed Sep 20, 2024

View reviewed changes

app/util/smart-transactions/smart-publish-hook.ts Show resolved Hide resolved

tommasini previously approved these changes Sep 20, 2024

View reviewed changes

cryptodev-2s requested a review from infiniteflower September 20, 2024 09:09

Merge remote-tracking branch 'origin/main' into jongsun/chore/bump/sm…

44b108d

…art-transactions-controller-13.0.0

cryptodev-2s dismissed tommasini’s stale review via 44b108d September 20, 2024 17:40

cryptodev-2s requested a review from tommasini September 20, 2024 17:43

cryptodev-2s and others added 2 commits September 20, 2024 20:12

Merge remote-tracking branch 'origin/main' into jongsun/chore/bump/sm…

f45252c

…art-transactions-controller-13.0.0

Merge branch 'main' into jongsun/chore/bump/smart-transactions-contro…

ef72a30

…ller-13.0.0

cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 20, 2024

tommasini previously approved these changes Sep 20, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into jongsun/chore/bump/sm…

cc44b52

…art-transactions-controller-13.0.0

cryptodev-2s dismissed tommasini’s stale review via cc44b52 September 20, 2024 20:25

cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Sep 20, 2024

tommasini approved these changes Sep 20, 2024

View reviewed changes

cryptodev-2s added this pull request to the merge queue Sep 20, 2024

Merged via the queue into main with commit 5275022 Sep 20, 2024
42 checks passed

cryptodev-2s deleted the jongsun/chore/bump/smart-transactions-controller-13.0.0 branch September 20, 2024 21:23

github-actions bot locked and limited conversation to collaborators Sep 20, 2024

metamaskbot added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Sep 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): Bump `@metamask/smart-transactions-controller` from `11.0.0` to `^13.0.0` #11140

chore(deps): Bump `@metamask/smart-transactions-controller` from `11.0.0` to `^13.0.0` #11140

MajorLift commented Sep 10, 2024 •

edited by cryptodev-2s

Loading

github-actions bot commented Sep 10, 2024

socket-security bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024 •

edited by metamaskbot

Loading

tommasini left a comment

github-actions bot commented Sep 20, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 20, 2024 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Sep 20, 2024

chore(deps): Bump @metamask/smart-transactions-controller from 11.0.0 to ^13.0.0 #11140

chore(deps): Bump @metamask/smart-transactions-controller from 11.0.0 to ^13.0.0 #11140

Conversation

MajorLift commented Sep 10, 2024 • edited by cryptodev-2s Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 10, 2024

socket-security bot commented Sep 10, 2024 • edited Loading

github-actions bot commented Sep 19, 2024

Bitrise

github-actions bot commented Sep 19, 2024 • edited by metamaskbot Loading

Bitrise

tommasini left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 20, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Sep 20, 2024 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Sep 20, 2024

Quality Gate passed

chore(deps): Bump `@metamask/smart-transactions-controller` from `11.0.0` to `^13.0.0` #11140

chore(deps): Bump `@metamask/smart-transactions-controller` from `11.0.0` to `^13.0.0` #11140

MajorLift commented Sep 10, 2024 •

edited by cryptodev-2s

Loading

socket-security bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 20, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Sep 20, 2024 •

edited by metamaskbot

Loading