SmartTransactionsController upgrade from v11 to v13 #11047
Assignees
Labels
release-7.33.0
Issue or pull request that will be included in release 7.33.0
team-transactions
Transactions team
team-wallet-framework
Comments
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 20, 2024
…0.0` to `^13.0.0` (#11140) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Bump @metamask/smart-transactions-controller from 11.0.0 to ^13.0.0 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: [#11047](#11047) ## **Manual testing steps** ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Salah-Eddine Saakoun <salah-eddine.saakoun@consensys.net> Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
metamaskbot
added
the
release-7.33.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
The
SmartTransactionControlleris behind by two major versions and needs to be updated.Upgrade from v11 to v13.
Scenario
n/a
Design
n/a
Technical Details
n/a
Threat Modeling Framework
n/a
Acceptance Criteria
SmartTransactionsControlleris on v13Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: