fix: gas never loading during send + high gas fee after deep link

[matthewwalsh0]

Description

Resolves two overlapping gas issues that were causing the gas fee to never finish loading during some wallet initiated send transactions, and for the gas fee estimate to be too high after using a deep link or QR code.

The gas fee estimates (and simulation details) were not loading as the simulation and gas fee polling in the TransactionController was silently failing due to recently added validations that were not compatible with the legacy ETHER_TRANSACTION type still being set in the Send view.

The resulting gas fee estimate was too high for deep links as the estimateGas call to the provider had an invalid value of 0 for the gasPrice which was resulting in an error response, and in turn setting the gasLimit to the fallback value of 95% of the block gas limit.

Additional error logging will be added to the TransactionController in future.

Related issues

Fixes: #10895 #10281

Manual testing steps

See issues.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1e130ba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b8e0169f-eef9-4fca-bca3-628327cfd425

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 60ef2cb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b92b94c-5fd5-4496-b4f1-58734d9a11fc

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud