Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Gas calcs way off for erc20s using QR codes or deeplinks. #10281

Closed
jjs2484 opened this issue Jul 10, 2024 · 2 comments
Closed

[Bug]: Gas calcs way off for erc20s using QR codes or deeplinks. #10281

jjs2484 opened this issue Jul 10, 2024 · 2 comments
Assignees
@matthewwalsh0
Labels
external-contributor regression-prod-7.24.4 Regression bug that was found in production in release 7.24.4 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-confirmations Push issues to confirmations team team-transactions Transactions team type-bug Something isn't working

Comments

@jjs2484
Copy link

jjs2484 commented Jul 10, 2024

Describe the bug

Gas calcs are way off for erc20s on ETH mainnet. Checked USDC, USDT, and BAT. See picture. ETH seems OK.
.

Expected behavior

No response

Screenshots/Recordings

Screenshot_20240710_103222_MetaMask (1)

Steps to reproduce

  1. Scan a payment QR code ( ethereum:0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48/transfer?address=0xAa28AA0140d13Ce38c804aCf66de4269E9D0CBE6&uint256=2.2e6 ) OR click a deeplink.

Error messages or log output

No response

Version

7.24.4

Build type

None

Device

Samsung galaxy

Operating system

Android

Additional context

No response

Severity

No response
@jjs2484 jjs2484 added the type-bug Something isn't working label Jul 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jul 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jul 10, 2024
@metamaskbot metamaskbot added external-contributor regression-prod-7.24.4 Regression bug that was found in production in release 7.24.4 labels Jul 10, 2024
@jpcloureiro jpcloureiro added Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-sdk SDK team labels Jul 11, 2024
@gauthierpetetin
Copy link
Contributor

Hi @MetaMask/sdk-devs , has there been any investigation made on this sev1 issue?

@gauthierpetetin gauthierpetetin added team-confirmations Push issues to confirmations team team-transactions Transactions team and removed team-sdk SDK team team-confirmations Push issues to confirmations team labels Aug 27, 2024
@gauthierpetetin
Copy link
Contributor

Re-assigning to @MetaMask/transactions as it doesn't seem related to sdk.

@digiwand digiwand assigned digiwand and unassigned digiwand Aug 27, 2024
@digiwand digiwand added the team-confirmations Push issues to confirmations team label Aug 27, 2024
@matthewwalsh0 matthewwalsh0 self-assigned this Aug 27, 2024
@matthewwalsh0 matthewwalsh0 mentioned this issue Aug 31, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Sep 6, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewwalsh0 matthewwalsh0

Labels
external-contributor regression-prod-7.24.4 Regression bug that was found in production in release 7.24.4 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-confirmations Push issues to confirmations team team-transactions Transactions team type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jpcloureiro @jjs2484 @gauthierpetetin @matthewwalsh0 @digiwand @metamaskbot