Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): hide profile sync toggle #10900

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Aug 29, 2024

Description

This feature is still under development and should not be shown.

This is to be ported into: 7.30.0

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1030

Manual testing steps

  1. Go through onboarding
  2. Visit advanced configuration
  3. The Profile Sync toggle should not be visible on mobile production

Screenshots/Recordings

Before

image

After

Screenshot 2024-08-29 at 18 30 55

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notifications team label Aug 29, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

this feature is still under development and should not be shown.
I'm unsure what the feature flag is, so have manually set this to false.
@Prithpal-Sooriya Prithpal-Sooriya force-pushed the NOTIFY-1030/hide-profile-sync-toggle branch from 86a782e to ed35d66 Compare August 29, 2024 17:28
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ed35d66
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d4e7bbc-9c09-4203-9e34-eda5b417e382

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review August 29, 2024 17:40
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner August 29, 2024 17:40
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 30, 2024
Copy link
Contributor

github-actions bot commented Aug 30, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 21ec51d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/17155c8a-6c27-483a-af6b-4a3e196d62f1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 30, 2024
@Prithpal-Sooriya Prithpal-Sooriya merged commit d98a1c9 into main Aug 30, 2024
47 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the NOTIFY-1030/hide-profile-sync-toggle branch August 30, 2024 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.31.0 Issue or pull request that will be included in release 7.31.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications Notifications team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants