-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(notifications): hide profile sync toggle (#10900)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This feature is still under development and should not be shown. This is to be ported into: 7.30.0 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1030 ## **Manual testing steps** 1. Go through onboarding 2. Visit advanced configuration 3. The Profile Sync toggle should not be visible on mobile production ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] -->  ### **After** <!-- [screenshots/recordings] -->  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information
1 parent
c2f9300
commit d98a1c9
Showing
4 changed files
with
13 additions
and
267 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 1 addition & 90 deletions
91
app/components/UI/ProfileSyncing/__snapshots__/ProfileSyncing.test.tsx.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,92 +1,3 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`ProfileSyncing should render correctly 1`] = ` | ||
| <View | ||
| style={ | ||
| { | ||
| "marginVertical": 16, | ||
| } | ||
| } | ||
| > | ||
| <View | ||
| style={ | ||
| { | ||
| "alignItems": "center", | ||
| "flexDirection": "row", | ||
| "justifyContent": "space-between", | ||
| "paddingBottom": 8, | ||
| } | ||
| } | ||
| > | ||
| <Text | ||
| accessibilityRole="text" | ||
| style={ | ||
| { | ||
| "color": "#141618", | ||
| "fontFamily": "EuclidCircularB-Bold", | ||
| "fontSize": 16, | ||
| "fontWeight": "700", | ||
| "letterSpacing": 0, | ||
| "lineHeight": 24, | ||
| } | ||
| } | ||
| > | ||
| Profile Sync | ||
| </Text> | ||
| <RCTSwitch | ||
| accessibilityRole="switch" | ||
| disabled={true} | ||
| onChange={[Function]} | ||
| onResponderTerminationRequest={[Function]} | ||
| onStartShouldSetResponder={[Function]} | ||
| onTintColor="#0376c9" | ||
| style={ | ||
| [ | ||
| { | ||
| "height": 31, | ||
| "width": 51, | ||
| }, | ||
| { | ||
| "backgroundColor": "#bbc0c566", | ||
| "borderRadius": 16, | ||
| }, | ||
| ] | ||
| } | ||
| thumbTintColor="#ffffff" | ||
| tintColor="#bbc0c566" | ||
| value={false} | ||
| /> | ||
| </View> | ||
| <Text | ||
| accessibilityRole="text" | ||
| style={ | ||
| { | ||
| "color": "#6a737d", | ||
| "fontFamily": "EuclidCircularB-Regular", | ||
| "fontSize": 14, | ||
| "fontWeight": "400", | ||
| "letterSpacing": 0, | ||
| "lineHeight": 22, | ||
| } | ||
| } | ||
| > | ||
| Creates a profile that MetaMask uses to sync some settings among your devices. This is required to get notifications. | ||
| <Text | ||
| accessibilityRole="text" | ||
| onPress={[Function]} | ||
| style={ | ||
| { | ||
| "color": "#0376c9", | ||
| "fontFamily": "EuclidCircularB-Regular", | ||
| "fontSize": 14, | ||
| "fontWeight": "400", | ||
| "letterSpacing": 0, | ||
| "lineHeight": 22, | ||
| } | ||
| } | ||
| > | ||
| Learn how we protect your privacy | ||
| </Text> | ||
| </Text> | ||
| </View> | ||
| `; | ||
| exports[`ProfileSyncing should render correctly 1`] = `null`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters