Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app crash due to minimal input must be string error #10842

Merged
merged 9 commits into from
Sep 11, 2024
Merged

fix: app crash due to minimal input must be string error #10842

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
46f3df3
fix: short term fix to silence sentry alert
vinnyhoward Aug 27, 2024
9a15d03
fix: added fallback values and fixing instances where minimalInput er…
vinnyhoward Sep 4, 2024
68afaf9
fix: reverted a change
vinnyhoward Sep 4, 2024
8fa9175
fix: reverted another change
vinnyhoward Sep 5, 2024
3fc7639
fix: removed unneeded to string method
vinnyhoward Sep 5, 2024
c752c26
fix: changed fallback 0 to hex 0x0
vinnyhoward Sep 5, 2024
694af47
Merge branch 'main' into fix-9077-minimal-input-must-be-string
vinnyhoward Sep 5, 2024
3ae5fbb
Merge branch 'main' into fix-9077-minimal-input-must-be-string
vinnyhoward Sep 6, 2024
c50eace
Merge branch 'main' into fix-9077-minimal-input-must-be-string
sethkfman Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions app/components/Views/confirmations/SendFlow/Amount/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,6 +887,7 @@ class Amount extends PureComponent {
contractExchangeRates,
} = this.props;
const { internalPrimaryCurrencyIsCrypto, estimatedTotalGas } = this.state;
const tokenBalance = contractBalances[selectedAsset.address] || '0x0';
let input;
if (selectedAsset.isETH) {
const balanceBN = hexToBN(accounts[selectedAddress].balance);
Expand All @@ -907,15 +908,12 @@ class Amount extends PureComponent {
: undefined;
if (internalPrimaryCurrencyIsCrypto || !exchangeRate) {
input = fromTokenMinimalUnitString(
contractBalances[selectedAsset.address]?.toString(10),
tokenBalance,
selectedAsset.decimals,
);
} else {
input = `${balanceToFiatNumber(
fromTokenMinimalUnitString(
contractBalances[selectedAsset.address]?.toString(10),
selectedAsset.decimals,
),
fromTokenMinimalUnitString(tokenBalance, selectedAsset.decimals),
conversionRate,
exchangeRate,
)}`;
Expand Down
Loading