fix: app crash due to minimal input must be string error

[vinnyhoward]

Description

This PR addresses the "minimal input must be string" error thrown by the fromTokenMinimalUnitString function when its first argument is not a string. This error causes a crash on the user's device.

Error logs from Senty point to the Send Flow. These changes help ensure that the fromTokenMinimalUnitString function always receives a string by using the hex fallback 0x0. This will stop the minimal input must be string error and associated app crashes

Related issues

Fixes: #9077

Manual testing steps

1. Go to the Send flow
2. Select an address to send to.
3. Select a token (Select a non Ethereum token)
4. Tap the MAX button
5. Verify that no errors occur and the maximum amount is correctly displayed

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 360e1de
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b650ff03-adf2-4131-a34e-d46bd9d98261

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 16adeec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/91fec3bd-60cc-410f-a6ef-b73ab50444d0

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.83%. Comparing base (8dcdd3c) to head (16adeec).
Report is 33 commits behind head on main.

Files with missing lines	Patch %	Lines
.../UI/Ramp/Views/SendTransaction/SendTransaction.tsx	0.00%	0 Missing and 1 partial ⚠️
...nents/Views/confirmations/SendFlow/Amount/index.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10842      +/-   ##
==========================================
+ Coverage   52.75%   52.83%   +0.07%     
==========================================
  Files        1534     1542       +8     
  Lines       36777    36887     +110     
  Branches     4335     4361      +26     
==========================================
+ Hits        19403    19488      +85     
- Misses      16058    16071      +13     
- Partials     1316     1328      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f630624
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/86ceea8e-d1ec-4d7c-9ebd-706602019ae6

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[gambinish]

This kind of bug definitely makes me want to get util/number/index.js refactored to Typescript 😅 but, it seems like this would be a tough file to convert.

Your description makes sense. I wonder if a more long term fix would be to address this in the fromTokenMinimalUnitString function itself? I'm not sure if forcing a fallback to '0' is acceptable here during send flow (maybe someone on Txn team can confirm if it is).

In any case, I think that we should probably write some unit tests to check for the cases you described in your PR description in util/number/index.test.ts to make sure that each function gets evaluated as we'd expect them to.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8fa9175
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cad85517-75b3-44db-9d51-c598a69b8b4b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3ae5fbb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6231978a-758b-4836-b1d6-99be5c31e511

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sethkfman]

LGTM