Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated in-app review to comply with SDK 14 on Android #10647

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Aug 14, 2024

Description

This PR bumps the in-app review package to comply with the updates to

Related issues

Fixes: #10198

Manual testing steps

  1. Build for Android and see successful submission

Screenshots/Recordings

NA

Before

Screenshot 2024-08-14 at 3 20 41 PM

After

Screenshot 2024-08-14 at 3 43 46 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman added Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-delivery labels Aug 14, 2024
@sethkfman sethkfman requested review from a team as code owners August 14, 2024 21:06
Copy link

socket-security bot commented Aug 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-native-in-app-review@4.3.3 None 0 60 kB minasamir
npm/semver@7.6.3 None 0 95.8 kB npm-cli-ops

🚮 Removed packages: npm/react-native-in-app-review@3.2.3, npm/semver@7.6.2

View full report↗︎

Copy link
Contributor

github-actions bot commented Aug 14, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6860404
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6b80ea03-b83d-4daa-87b6-c188d0e31388

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@sethkfman sethkfman merged commit 340e5ed into main Aug 15, 2024
32 of 33 checks passed
@sethkfman sethkfman deleted the chore/bump-in-app-review-package branch August 15, 2024 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade instances of com.google.android.play.core
4 participants